Skip to content

chore(ci): basic CI set up#28

Closed
vivjd wants to merge 4 commits into
mainfrom
chore-ci-setup
Closed

chore(ci): basic CI set up#28
vivjd wants to merge 4 commits into
mainfrom
chore-ci-setup

Conversation

@vivjd

@vivjd vivjd commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

Proposed Changes

Closes #3

Basic setup for CI pipeline for jest tests. Requires #36.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) x

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have requested a review from a project maintainer, and a fellow student.

Questions and Comments

@matt-dahlgren This is my first time setting up CI, could you take a look and see if there are any issues?

@vivjd vivjd marked this pull request as draft February 4, 2026 22:50
@vivjd

vivjd commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator Author

CI checks failing right now, I presume that's expected since frontend and backend aren't set up to these naming conventions right now?

This comment was marked as outdated.

@matt-dahlgren

Copy link
Copy Markdown
Collaborator

I do not think that we need two different CI's, one will suffice, and we will be able to set up job paths as we continue through this project. We do not have anything to build at the moment, so I don't think that we should be adding jobs for our CI to build just yet.

I left a suggestion on managing frontend vs backend tasks, and these can both be built within the same CI file. Moving to having just one CI will make the Pull Request process faster as well, as it will be one less environment to build (jest will be built twice in your configuration).

Comment thread .github/workflows/backend-ci.yml Outdated
@vivjd

vivjd commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator Author

@matt-dahlgren Thanks for the feedback! Updated the CI accordingly, still going to retain this as a draft until we rename our frontend and backend branches.

@vivjd

vivjd commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator Author

Closed as updated in #44

@vivjd vivjd closed this Mar 2, 2026
@vivjd vivjd deleted the chore-ci-setup branch March 27, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up CI/CD

3 participants