added sea level check on units and general level

Author: lily-tomkovic-DWR

test_suite/conftest.py

@@ -9,7 +9,10 @@ def pytest_addoption(parser):
         "--sim_dir",
         action="store",
         default=".",
-        help="Home directory of run (where param.nml sits)" "--sea_level",
+        help="Home directory of run (where param.nml sits)",
+    ),
+    parser.addoption(
+        "--sea_level",
         action="store",
         default=0.97,
         help="Expected sea level (0.97 m is default)",
@@ -19,11 +22,16 @@ def pytest_addoption(parser):
 @pytest.fixture(scope="module")
 def sim_dir(request):
     loc = request.config.getoption("--sim_dir")
+    loc = "/scratch/tomkovic/schism_repos/bdschism_pytest"
     return os.path.abspath(loc)
 
+
 @pytest.fixture(scope="module")
 def params(sim_dir):
-    fname = os.path.join(sim_dir,"param.nml")
+    fname = os.path.join(sim_dir, "param.nml")
     return parms.read_params(fname)
-    
-    
+
+
+@pytest.fixture(scope="module")
+def sea_level(request):
+    return request.config.getoption("--sea_level")

test_suite/test_elev2d.py

@@ -3,6 +3,7 @@
 import pytest
 import os
 import xarray as xr
+import numpy as np
 import datetime
 
 
@@ -19,3 +20,36 @@ def test_elev2d_time(sim_dir, params):
     assert (
         elev_start == param_start
     ), f"elev2D.th.nc file start time {elev_start.strftime('%Y-%m-%d %H:%M')} does not match the param.nml start time {param_start.strftime('%Y-%m-%d %H:%M')}"
+
+
+@pytest.mark.prerun
+def test_sea_level(sim_dir, sea_level):
+    elev_df = xr.open_dataset(
+        os.path.join(sim_dir, "elev2D.th.nc")
+    )  # shape is elev_df.time_series[timesteps, openboundarynodes, nlevels]
+
+    mean_sea_level = elev_df.time_series[:, :, :].mean().item()
+
+    nmon = int(
+        ((elev_df.time.values[-1] - elev_df.time.values[0]) / np.timedelta64(1, "D"))
+        / 30.44
+    )
+
+    sigma = min(0.4, 0.1 + 0.25 / nmon)
+
+    assert (
+        abs(sea_level - mean_sea_level) < sigma
+    ), f"Mean sea level {mean_sea_level:.2f} is not within {sigma:.2f} of expected sea level {sea_level:.2f}"
+
+
+@pytest.mark.prerun
+def test_sea_level_units(sim_dir):
+    elev_df = xr.open_dataset(
+        os.path.join(sim_dir, "elev2D.th.nc")
+    )  # shape is elev_df.time_series[timesteps, openboundarynodes, nlevels]
+
+    std_dev = elev_df.time_series.std(dim=("nOpenBndNodes", "nLevels"))
+
+    assert (
+        std_dev.max().item() < 1.0
+    ), f"Standard deviation of sea level is too high for units of meters, check download data for possible use of feet. Max standard deviation: {std_dev:.2f}"