Skip to content

Commit a90c7ed

Browse files
committed
feat: Update selected row resolution in TransformToCatalogAction to include hidden metadata columns
1 parent 694cdab commit a90c7ed

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

dvue/actions.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,12 @@ def callback(self, event, dataui):
587587

588588
from .math_reference import MathDataReference
589589

590-
selected_rows = dataui.display_table.selected_dataframe
590+
# Resolve selected rows from _dfcat (all catalog columns) via selection
591+
# indices into display_table.value. Using selected_dataframe would omit
592+
# hidden metadata columns that get_data_reference() needs.
593+
_selection = dataui.display_table.selection
594+
_sel_index = dataui.display_table.value.iloc[_selection].index
595+
selected_rows = dataui._dfcat.loc[_sel_index]
591596
added_names = []
592597
id_col = self._get_id_column(manager, catalog)
593598

tests/test_tsdataui.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,7 @@ def _add_ref_and_run(self, extra_attrs=None, **transform_params):
655655
fake_dataui = MagicMock()
656656
fake_dataui._dataui_manager = mgr
657657
fake_dataui.display_table.selection = [0]
658+
fake_dataui.display_table.value = dfcat
658659
fake_dataui._dfcat = dfcat
659660

660661
with patch("panel.state") as mock_state:
@@ -707,6 +708,7 @@ def test_tag_attribute_set_when_no_F(self):
707708
fake_dataui = MagicMock()
708709
fake_dataui._dataui_manager = mgr
709710
fake_dataui.display_table.selection = [0]
711+
fake_dataui.display_table.value = dfcat
710712
fake_dataui._dfcat = dfcat
711713

712714
with patch("panel.state") as mock_state:

0 commit comments

Comments
 (0)