Better message over entirely missing data for a column.

Author: Eli

schimpy/merge_th.py

@@ -207,8 +207,15 @@ def merge_th(th_spec):
         colmissing = colmissing[colmissing > 0]
 
         if colmissing.any():
-            print("Missing data in columns:")
-            print(colmissing)
+            nrows = len(mdf)
+            entirely_absent = colmissing[colmissing == nrows]
+            has_gaps = colmissing[colmissing < nrows]
+            if not entirely_absent.empty:
+                print("Columns not found in any input data source (label mismatch?):")
+                print(entirely_absent.index.tolist())
+            if not has_gaps.empty:
+                print("Columns found but with temporal gaps (missing values):")
+                print(has_gaps)
             print(mdf.loc[mdf.isnull().any(axis=1), :])
             mdf.loc[mdf.isnull().any(axis=1), :].to_csv("missing.csv")
             raise ValueError(

schimpy/prepare_schism.py

@@ -826,10 +826,11 @@ def prepare_schism(args, use_logging=True):
 
         # If mesh already loaded above, reuse it
         for bctides_out in bctides_items:
-            logger.info(f"Processing bctides YAML: {bctides_out}")
-            by = load_boundary(hgrid, bctides_items[bctides_out], None)
-            # Output file name: use YAML path or key
-            by.write_bctides(bctides_out)
+            out_name = bctides_out["name"]
+            logger.info(f"Processing bctides YAML: {out_name}")
+            by = load_boundary(hgrid, bctides_out, None)
+            out_path = ensure_outdir(inputs["prepro_output_dir"], out_name)
+            by.write_bctides(out_path)
 
 
     if item_exist(inputs, "copy_resources"):