Skip to content

Remove un-commented rows and fix ambiguous method call#9

Open
UnsavedWings wants to merge 1 commit into
CASP-Systems-BU:mainfrom
UnsavedWings:fix/uncommented-rows-and-ambiguous-call
Open

Remove un-commented rows and fix ambiguous method call#9
UnsavedWings wants to merge 1 commit into
CASP-Systems-BU:mainfrom
UnsavedWings:fix/uncommented-rows-and-ambiguous-call

Conversation

@UnsavedWings

Copy link
Copy Markdown

Function namespace and argument updates:

  • Updated calls to ripple_carry_adder and parallel_prefix_adder to use the explicit orq::operators namespace in micro_boolean_addition.cpp for correctness
  • Updated all sort method calls in ex5_join.cpp to explicitly pass a std::vector<std::string> instead of using initializer lists, avoiding ambiguity

Code cleanup:

  • Removed outdated usage comments from the beginning of main functions in micro_ccs_radix.cpp and micro_sorting_rs.cpp

Compiler Output:

user@machine:~/orq/build$ make -j 16
/home/user/orq/bench/micro/micro_boolean_addition.cpp: In function ‘int main(int, char**)’:
/home/user/orq/bench/micro/micro_boolean_addition.cpp:24:35: error: ‘ripple_carry_adder’ is not a member of ‘orq’; did you mean ‘orq::operators::ripple_carry_adder’?
   24 |     BSharedVector<int> c_1 = orq::ripple_carry_adder(a, b);
      |                                   ^~~~~~~~~~~~~~~~~~
/home/user/orq/examples/ex5_join.cpp: In function ‘int main(int, char**)’:
/home/user/orq/examples/ex5_join.cpp:112:26: error: call of overloaded ‘sort(<brace-enclosed initializer list>)’ is ambiguous
  112 |         StudentCount.sort({ENC_TABLE_VALID, "[StudentID]"});
      |         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/user/orq/bench/micro/micro_ccs_radix.cpp: In function ‘int main(int, char**)’:
/home/user/orq/bench/micro/micro_ccs_radix.cpp:13:7: error: ‘executable’ was not declared in this scope; did you mean ‘execle’?
   13 |      [executable - threads_num - p_factor -
      |       ^~~~~~~~~~
      |       execle
/home/user/orq/bench/micro/micro_ccs_radix.cpp:13:17: error: expected ‘,’ before ‘-’ token
   13 |      [executable - threads_num - p_factor -
      |                 ^~
      |                 ,
/home/user/orq/bench/micro/micro_ccs_radix.cpp:13:18: error: expected identifier before ‘-’ token
   13 |      [executable - threads_num - p_factor -
      |                  ^
/home/user/orq/bench/micro/micro_ccs_radix.cpp:15:25: error: expected ‘]’ before ‘;’ token
   15 |     orq_init(argc, argv);
      |                         ^
      |                         ]
      ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant