Fix queuedCommands memory leak in CefDevToolsClient

S1artie · magreenblatt · commit 7ac5c1f692c6 · 2026-01-05T16:54:14.000Z
diff --git a/java/org/cef/browser/CefDevToolsClient.java b/java/org/cef/browser/CefDevToolsClient.java
@@ -36,6 +36,7 @@ public void onDevToolsMethodResult(
                     future.completeExceptionally(
                             new DevToolsException("DevTools method failed", result));
                 }
+                removeQueuedCommand(messageId);
             }
 
             @Override
@@ -62,6 +63,10 @@ private CompletableFuture<String> getQueuedCommand(Integer messageId) {
         return queuedCommands_.computeIfAbsent(messageId, key -> new CompletableFuture<>());
     }
 
+    private void removeQueuedCommand(Integer messageId) {
+        queuedCommands_.remove(messageId);
+    }
+
     /**
      * Execute a method call over the DevTools protocol. See the <a
      * href=https://chromedevtools.github.io/devtools-protocol/> DevTools protocol documentation</a>

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ public void onDevToolsMethodResult(`
`36`	`36`	`future.completeExceptionally(`
`37`	`37`	`new DevToolsException("DevTools method failed", result));`
`38`	`38`	`}`
	`39`	`+ removeQueuedCommand(messageId);`
`39`	`40`	`}`
`40`	`41`
`41`	`42`	`@Override`
`@@ -62,6 +63,10 @@ private CompletableFuture<String> getQueuedCommand(Integer messageId) {`
`62`	`63`	`return queuedCommands_.computeIfAbsent(messageId, key -> new CompletableFuture<>());`
`63`	`64`	`}`
`64`	`65`
	`66`	`+ private void removeQueuedCommand(Integer messageId) {`
	`67`	`+ queuedCommands_.remove(messageId);`
	`68`	`+ }`
	`69`	`+`
`65`	`70`	`/**`
`66`	`71`	`* Execute a method call over the DevTools protocol. See the <a`
`67`	`72`	`* href=https://chromedevtools.github.io/devtools-protocol/> DevTools protocol documentation</a>`