refactor(ci): isolate test cache using mock patch and addCleanup

Author: MrButtCode

tests/base.py

@@ -2,6 +2,7 @@
 
 import os
 import warnings
+import utility
 from collections import namedtuple
 from contextlib import contextmanager
 from unittest import mock
@@ -278,6 +279,14 @@ def create_app(self, mock_config, mock_storage_client):
 
     def setUp(self):
         """Set up all entities."""
+        # Patch the cache before parent setup runs to prevent HTTP calls
+        self.cache_patcher = mock.patch.object(
+            utility, 'cache_has_expired', return_value=False
+        )
+        self.cache_patcher.start()
+        self.addCleanup(self.cache_patcher.stop)
+
+        super().setUp()
         self.app.preprocess_request()
         g.db = create_session(
             self.app.config['DATABASE_URI'], drop_tables=True)
@@ -396,6 +405,10 @@ def setUp(self):
         g.db.add_all(forbidden_ext)
         g.db.commit()
 
+    def tearDown(self):
+        """Clean up after every test."""
+        super().tearDown()
+
     @staticmethod
     def create_login_form_data(email, password) -> dict:
         """

utility.py

@@ -89,13 +89,6 @@ def cache_has_expired() -> bool:
     :rtype: bool
     """
     global cached_load_time
-    import sys
-
-    # Foolproof bypass: if a test framework is running in the Python
-    # interpreter, bypass the cache to prevent mock pollution.
-    if 'nose' in sys.modules or 'unittest' in sys.modules:
-        return True
-
     from datetime import datetime, timedelta
     return cached_load_time + timedelta(hours=1) < datetime.now()