Skip to content

Commit 49deac5

Browse files
committed
Fixed sonarqube code smell
1 parent 5cf50d6 commit 49deac5

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

tests/api/test_middleware_auth.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ def test_revoked_token(self):
7575
self.assertEqual(res.status_code, 401)
7676

7777
def test_expired_token(self):
78-
plaintext, token = self.get_token(self.user, expires_in_days=-1)
78+
plaintext, _ = self.get_token(self.user, expires_in_days=-1)
7979
res = self.client.get('/api/v1/system/queue',
8080
headers={'Authorization': f'Bearer {plaintext}'})
8181
self.assertEqual(res.status_code, 401)
8282

8383
def test_valid_token_missing_scope(self):
8484
# /api/v1/system/queue requires 'system:read'
85-
plaintext, token = self.get_token(self.user, scopes=['runs:read'])
85+
plaintext, _ = self.get_token(self.user, scopes=['runs:read'])
8686
res = self.client.get('/api/v1/system/queue',
8787
headers={'Authorization': f'Bearer {plaintext}'})
8888
self.assertEqual(res.status_code, 403)
@@ -91,29 +91,29 @@ def test_valid_token_missing_scope(self):
9191
self.assertIn('missing_scopes', res.json['details'])
9292

9393
def test_valid_token_with_scope(self):
94-
plaintext, token = self.get_token(self.user, scopes=['system:read'])
94+
plaintext, _ = self.get_token(self.user, scopes=['system:read'])
9595
res = self.client.get('/api/v1/system/queue',
9696
headers={'Authorization': f'Bearer {plaintext}'})
9797
self.assertEqual(res.status_code, 200)
9898

9999
def test_role_decorator_missing_role(self):
100100
# GET /api/v1/auth/tokens requires 'tokens:manage' and roles ['admin', 'contributor', 'tester']
101-
plaintext, token = self.get_token(
101+
plaintext, _ = self.get_token(
102102
self.user, scopes=['tokens:manage']) # role is user
103103
res = self.client.get('/api/v1/auth/tokens',
104104
headers={'Authorization': f'Bearer {plaintext}'})
105105
self.assertEqual(res.status_code, 403)
106106
self.assertEqual(res.json['code'], 'forbidden')
107107

108108
def test_role_decorator_with_role(self):
109-
plaintext, token = self.get_token(
109+
plaintext, _ = self.get_token(
110110
self.admin, scopes=['tokens:manage']) # role is admin
111111
res = self.client.get('/api/v1/auth/tokens',
112112
headers={'Authorization': f'Bearer {plaintext}'})
113113
self.assertEqual(res.status_code, 200)
114114

115115
def test_scope_boundary_write_endpoints_fail_on_read_only_scopes(self):
116-
plaintext, token = self.get_token(
116+
plaintext, _ = self.get_token(
117117
self.user, scopes=['runs:read', 'results:read'])
118118

119119
# 1. POST /runs

tests/api/test_services_log_service.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_read_log_lines_limit_clamped(self, mock_get_path):
6868
path = self.create_log_file(content)
6969
mock_get_path.return_value = path
7070

71-
lines, next_cursor = read_log_lines(1, limit=2000)
71+
lines, _ = read_log_lines(1, limit=2000)
7272
# Should be clamped to 500
7373
self.assertEqual(len(lines), 500)
7474

@@ -79,16 +79,16 @@ def test_read_log_lines_filters(self, mock_get_path):
7979
mock_get_path.return_value = path
8080

8181
# Filter by level
82-
lines, next_cursor = read_log_lines(1, level='error')
82+
lines, _ = read_log_lines(1, level='error')
8383
self.assertEqual(len(lines), 1)
8484
self.assertEqual(lines[0]['message'], "ERROR build: Failed")
8585

8686
# Filter by source
87-
lines, next_cursor = read_log_lines(1, source='build')
87+
lines, _ = read_log_lines(1, source='build')
8888
self.assertEqual(len(lines), 2)
8989

9090
# Filter by contains
91-
lines, next_cursor = read_log_lines(1, contains='STARTING')
91+
lines, _ = read_log_lines(1, contains='STARTING')
9292
self.assertEqual(len(lines), 1)
9393

9494
@patch('mod_api.services.log_service.get_log_file_path')

0 commit comments

Comments
 (0)