refactor(ci): convert cache expiration to pure function per review

Author: MrButtCode

tests/base.py

@@ -4,7 +4,6 @@
 import warnings
 from collections import namedtuple
 from contextlib import contextmanager
-from unittest import mock
 
 from flask import g
 from flask_testing import TestCase
@@ -279,12 +278,13 @@ def create_app(self, mock_config, mock_storage_client):
 
     def setUp(self):
         """Set up all entities."""
-        # Patch the cache before parent setup runs to prevent HTTP calls
-        self.cache_patcher = mock.patch.object(
-            utility, 'cache_has_expired', return_value=False
-        )
-        self.cache_patcher.start()
-        self.addCleanup(self.cache_patcher.stop)
+        from datetime import datetime
+
+        import utility
+
+        # Reset the state directly for test isolation. No mocks needed!
+        utility.cached_load_time = datetime(1970, 1, 1)
+        utility.cached_web_hook_blocks = []
 
         super().setUp()
         self.app.preprocess_request()

utility.py

@@ -81,16 +81,15 @@ def decorated_function(*args, **kwargs):
 cached_load_time: datetime = datetime(1970, 1, 1)
 
 
-def cache_has_expired() -> bool:
+def cache_has_expired(load_time: datetime) -> bool:
     """
     Check if the cache expired.
 
     :return: True if the cache was last updated more than one hour ago.
     :rtype: bool
     """
-    global cached_load_time
     from datetime import datetime, timedelta
-    return cached_load_time + timedelta(hours=1) < datetime.now()
+    return load_time + timedelta(hours=1) < datetime.now()
 
 
 def is_github_web_hook_ip(request_ip: Union[IPv4Address, IPv6Address]) -> bool:
@@ -120,7 +119,7 @@ def get_cached_web_hook_blocks() -> List[str]:
     global cached_load_time
     from run import config
 
-    if len(cached_web_hook_blocks) == 0 or cache_has_expired():
+    if len(cached_web_hook_blocks) == 0 or cache_has_expired(cached_load_time):
         client_id = config.get('GITHUB_CLIENT_ID', '')
         client_secret = config.get('GITHUB_CLIENT_KEY', '')
         meta_json = requests.get(