Skip to content

[FIX]: Stop rendering "Pass" for regression tests with no test_result row #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Jun 24, 2026
+3 −3
Merged

[FIX]: Stop rendering "Pass" for regression tests with no test_result row #1136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/test/by_id.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,16 @@ <h4 class="category-header {{ 'fail' if result.error else 'pass' }}" data-catego
{%- endif %}
{%- endfor %}
{%- endif %}
{% if test.result.exit_code != test.result.expected_rc %}
{% if test.result and test.result.exit_code != test.result.expected_rc %}
{% if file.got is none or no_error.found-%}
Fail
{% else %}
<a href="#" class="diff_link" data-test="{{ file.test_id }}" data-regression="{{ file.regression_test_id }}" data-output="{{ file.regression_test_output_id }}">Fail</a>
{%- endif %}
{% elif file.got is none or no_error.found or test.result.exit_code != 0 -%}
Pass
{% elif file.got == "error" %}
No output generated but there should be
{% elif file.got is none or no_error.found or (test.result and test.result.exit_code != 0) -%}
Pass
{% else %}
<a href="#" class="diff_link" data-test="{{ file.test_id }}" data-regression="{{ file.regression_test_id }}" data-output="{{ file.regression_test_output_id }}">Fail</a>
{%- endif %}
Expand Down
Loading