Split Conformational Analysis into Explicit Serial Phases#367
Merged
Conversation
jimboid
approved these changes
Jun 16, 2026
jimboid
left a comment
Member
There was a problem hiding this comment.
More prep for further work on the parallel implementation. I will approve this on the basis that the cyclohexane regression test is looked at, since I will be at a conference the next two days and won't respond as quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the existing serial conformational analysis into explicit phases without changing execution behaviour. The current two-pass conformational workflow is preserved, but the logic is now separated into clearer steps for angle collection, peak construction, state assignment, flexible-dihedral counting, and final output merging. This prepares the conformational analysis for a future chunked map-reduce implementation.
Changes
Split peak-identification workflow into explicit phases:
_collect_dihedral_angle_data(...)._build_peak_data(...)._identify_peaks(...)as a serial orchestration wrapper around the new phase helpers.DihedralAngleDataandDihedralPeakDatacontainers to make intermediate phase outputs explicit.Split state-assignment workflow into explicit phases:
_calculate_group_state_data(...)._merge_group_state_data(...)._assign_states(...)as a serial orchestration wrapper around the new phase helpers.ConformationStateDatato represent state labels and flexible-dihedral counts before final output construction.Update atomic unit tests:
Impact
Dihedral.run(...)uses analysis-universe frame bounds, whileresults.anglesis indexed locally from zero.