You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: utilities/comparison-fixtures/bugs/README.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -17,7 +17,7 @@ with `DATABASE_VERSION=6.0.18.1`.
17
17
| --- | --- | --- | --- |
18
18
|[01](./01_sp_get_date_dim/)|`sp_get_date_dim` references nonexistent `dbo.rdb_date_temp`; also has an inverted-IF logic bug |**Resolved — non-issue.** RDB_DATE is correctly populated by seeds in normal environments; SP is not on the live path. Separate seed-correction PR in-flight. |`014-sp_get_date_dim-001.sql`|
19
19
|[02](./02_sp_contact_record_event/)|`sp_contact_record_event` references `nbs_odse.dbo.fn_get_value_by_cd_codeset` (function lives in `RDB_MODERN.dbo`) |**Already fixed on main** via PR #769 (commit `a0dbf3be`). |`069-sp_contact_record_event-001.sql:69`|
20
-
|[03](./03_morb_rpt_user_comment/)|`sp_d_morbidity_report_postprocessing` self-defeating join+filter at lines 802-816 |**Resolved — fix on branch `aw/app-471/bug-3` (commit `a32456a8`), PR pending.**|`016-sp_nrt_morbidity_report_postprocessing-001.sql:802-816`|
20
+
|[03](./03_morb_rpt_user_comment/)|`sp_d_morbidity_report_postprocessing` self-defeating join+filter at lines 802-816 |**PR #837 open** on branch `aw/app-471/bug-3`.|`016-sp_nrt_morbidity_report_postprocessing-001.sql:802-816`|
21
21
|[04](./04_provider_postprocessing_typo/)|`sp_nrt_provider_postprocessing` line 564 typo: `#PATIENT_UPDATE_LIST` should be `#PROVIDER_UPDATE_LIST`|**Merged on main** (PR #826, commit `92a56d42`). |`003-sp_nrt_provider_postprocessing-001.sql:564`|
22
22
|[05](./05_tmp_f_page_case_family/)|**TWO bugs**: (5a) `sp_hepatitis_datamart_postprocessing` logs incorrect row_count for #TMP_F_PAGE_CASE due to `IF @debug` resetting `@@ROWCOUNT` (logging-only); (5b) `nrt_investigation.patient_id NULL` cascades through PATIENT sentinel into a `DELETE WHERE PATIENT_UID IS NULL` (fixture-side; actual blocker for HEPATITIS_DATAMART) | High (5b blocks HEPATITIS_DATAMART population) |`013-sp_hepatitis_datamart_postprocessing-001.sql:108-111, 2149` + fixture `nrt_investigation`|
23
23
|[06](./06_ldf_data_truncation/)|`sp_nrt_ldf_postprocessing` maps `metadata_record_status_cd` ('LDF_PROCESSED', 13 chars) into `LDF_DATA.RECORD_STATUS_CD` (varchar(8) with CHECK constraint for 'ACTIVE'/'INACTIVE'). **Wrong source column**, not a width oversight. |**Merged on main** (PR #827, commit `bb882115`). |`015-sp_nrt_ldf_postprocessing-001.sql:863, 1006, 1132`|
@@ -62,13 +62,13 @@ investigation**. Worth noting because they reshape the picture:
62
62
| --- | --- | --- |
63
63
|#1| Resolved — non-issue | RDB_DATE is correctly populated by seeds in normal environments; the SP is not on the live path. Separate seed-correction PR in-flight. |
64
64
|#2| Fixed on main | PR #769 (commit `a0dbf3be`), pre-dates this investigation. |
65
-
|#3|Resolved — fix on branch `aw/app-471/bug-3` (commit `a32456a8`), PR pending. | RTR fix, query rewrite: replaced self-defeating join with staging-side walk via `nrt_morbidity_observation.followup_observation_uid` CSV filtered to `obs_domain_cd_st_1 = 'C_Result'`. Stays inside RDB_MODERN (no cross-DB ODSE read — see STRATEGY.md convention). |
65
+
|#3|PR #837 open on `aw/app-471/bug-3`. | RTR fix, query rewrite: replaced self-defeating join with staging-side walk via `nrt_morbidity_observation.followup_observation_uid` CSV filtered to `obs_domain_cd_st_1 = 'C_Result'`. Stays inside RDB_MODERN (no cross-DB ODSE read — see STRATEGY.md convention). |
66
66
|#4| Merged on main | PR #826 (commit `92a56d42`). |
67
67
| #5a | Open — local branch `aw/app-471/bug-5`; no PR yet. | RTR fix, line swap — capture `@@ROWCOUNT` before debug SELECT. Logging-only; no behavioral impact. |
68
68
| #5b | Open — fixture-side orchestrator change committed only on `aw/app-471/bug-5`. | Needs merge into `aw/odse-test-seed`. Single highest-ROI unlock for HEPATITIS_DATAMART (0 → 1 row in end-to-end merge). |
69
69
|#6| Merged on main | PR #827 (commit `bb882115`). |
0 commit comments