Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to resolve the race condition between the PostProcessingService and the Kafka Sink Connector for observation data, the ObservationService code was updated to directly persist to the following tables:
Related Issue
APP-519
Additional Notes
ObservationService.javaclass was previously responsible for listening for Kafka messages as well as some of the business logic for processing the messages. It has been renamed toObservationConsumer.javaand updated to only validate messages and extractOrganization_uidvalues. The newObservationProcessor.javaclass now handles the business logic of processing the data.NrtObservationWriteris using raw sql upsert statements, with a few more hours work, JPA Repositories could be created with@Entity's defined for each table to handle the insert/update if desired.ProcessObservationDataUtil.java, that was responsible for both parsing the Observation data and posting messages to the relevant Kafka Topics. This was split into anObservationParser.javaand theNrtObservationWriter.java.Checklist