add Cluster Autoscaler IRSA role and policy#313
Open
EmmanuelNwa247 wants to merge 2 commits into
Open
Conversation
|
EmmanuelNwa247
marked this pull request as ready for review
July 8, 2026 16:06
EmmanuelNwa247
requested review from
cmansky,
jolson490,
mww59,
rin-skylight and
szamfir-skylight
as code owners
July 8, 2026 16:06
jolson490
approved these changes
Jul 8, 2026
mww59
approved these changes
Jul 9, 2026
cmansky
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add IRSA (IAM Role for Service Accounts) support for the Cluster Autoscaler in the eks-nbs module. The autoscaler Helm chart was previously deployed on dev71 without IAM permissions — the ServiceAccount had no role annotation, so it couldn't call AWS APIs to scale nodes.
Changes
cluster_autoscaler_irsa_rolemodule andcluster_autoscaler_irsa_policyIAM policy with tag-scoped autoscaling permissionscreate_cluster_autoscaler_irsa(bool) andcluster_autoscaler_cluster_name(string) variables, both defaulting to off so existing environments are unaffectedcluster_autoscaler_irsa_role_arnoutputIAM Policy Details
DescribeAutoScalingGroups, DescribeTags, DescribeInstanceTypes, eks:DescribeNodegroup, etc.) useResource: "*"as these APIs don't support resource-level restrictionsSetDesiredCapacity, TerminateInstanceInAutoScalingGroup) are scoped via k8s.io/cluster-autoscalertag-based IAM conditions per upstream Cluster Autoscaler best practicesResource: "*"findings reviewed and safe to dismissValidation
helm installwith--setfor the SA annotationAccessDeniederrors, scale-down evaluation running on all nodescluster-autoscaler-9.58.0