Remove validate() as a mandatory method for RandomVariable and Model (#745)

Author: dylanhmorris

docs/tutorials/random_variables.qmd

@@ -191,7 +191,6 @@ subclasses to implement:
 | Method | Signature | Purpose |
 |--------|-----------|---------|
 | `sample` | `sample(**kwargs) -> tuple` | Core computation: return a value, draw from a distribution, or perform a calculation |
-| `validate` | `validate(**kwargs) -> None` | Check that parameters are well-formed; raise an error if not |
 
 The metaclass also provides:
 
@@ -512,7 +511,6 @@ and weekday peaks that is characteristic of real hospital admissions data.
 ### Writing a custom RandomVariable
 
 1. Subclass `RandomVariable` from `pyrenew.metaclass`
-2. Implement `validate()` as a `@staticmethod`; call it in `__init__`
 3. Implement `sample(**kwargs)` returning a `tuple`
 4. Use `numpyro.sample()` for quantities to be estimated
 5. Use `numpyro.deterministic()` to record derived quantities in the trace

pyrenew/deterministic/deterministic.py

@@ -33,39 +33,10 @@ def __init__(
         None
         """
         super().__init__(name=name)
-        self.validate(value)
         self.value = value
 
         return None
 
-    @staticmethod
-    def validate(value: ArrayLike) -> None:
-        """
-        Validates input to DeterministicVariable
-
-        Parameters
-        ----------
-        value
-            An ArrayLike object.
-
-        Returns
-        -------
-        None
-
-        Raises
-        ------
-        Exception
-            If the input value object is not an ArrayLike object.
-        """
-        if not isinstance(value, ArrayLike):
-            raise ValueError(
-                f"value {value} passed to a DeterministicVariable "
-                f"is of type {type(value).__name__}, expected "
-                "an ArrayLike object"
-            )
-
-        return None
-
     def sample(
         self,
         record: bool = False,

pyrenew/deterministic/deterministicpmf.py

@@ -54,22 +54,6 @@ def __init__(
 
         return None
 
-    @staticmethod
-    def validate(value: ArrayLike) -> None:
-        """
-        Validates input to DeterministicPMF
-
-        Parameters
-        ----------
-        value
-            An ArrayLike object.
-
-        Returns
-        -------
-        None
-        """
-        return None
-
     def sample(
         self,
         **kwargs: object,

pyrenew/deterministic/nullrv.py

@@ -19,21 +19,9 @@ def __init__(self) -> None:
         None
         """
         RandomVariable.__init__(self, name="null")
-        self.validate()
 
         return None
 
-    @staticmethod
-    def validate() -> None:
-        """
-        Not used
-
-        Returns
-        -------
-        None
-        """
-        return None
-
     def sample(
         self,
         **kwargs: object,
@@ -64,21 +52,9 @@ def __init__(self) -> None:
         None
         """
         RandomVariable.__init__(self, name="null_observation")
-        self.validate()
 
         return None
 
-    @staticmethod
-    def validate() -> None:
-        """
-        Not used
-
-        Returns
-        -------
-        None
-        """
-        return None
-
     def sample(
         self,
         mu: ArrayLike,

pyrenew/latent/base.py

@@ -286,24 +286,6 @@ def get_required_lookback(self) -> int:
         """
         return len(self.gen_int_rv())
 
-    @abstractmethod
-    def validate(self) -> None:
-        """
-        Validate latent process parameters.
-
-        Subclasses must implement this method to validate all parameters specific
-        to their implementation (e.g., temporal process parameters, I0 parameters).
-
-        Common validation (n_initialization_points, gen_int_rv) is performed in
-        __init__. Population structure validation is performed at sample time.
-
-        Raises
-        ------
-        ValueError
-            If any parameters fail validation
-        """
-        pass  # pragma: no cover
-
     @abstractmethod
     def sample(
         self,

pyrenew/latent/hierarchical_priors.py

@@ -51,10 +51,6 @@ def __init__(
         super().__init__(name=name)
         self.sd_rv = sd_rv
 
-    def validate(self) -> None:
-        """Validate the random variable (no-op for this class)."""
-        pass
-
     def sample(self, n_groups: int, **kwargs: object) -> ArrayLike:
         """
         Sample group-level effects.
@@ -136,10 +132,6 @@ def __init__(
         self.sd_concentration_rv = sd_concentration_rv
         self.sd_min = sd_min
 
-    def validate(self) -> None:
-        """Validate the random variable (no-op for this class)."""
-        pass
-
     def sample(self, n_groups: int, **kwargs: object) -> ArrayLike:
         """
         Sample group-level standard deviations.
@@ -220,10 +212,6 @@ def __init__(
         self.sd_rv = sd_rv
         self.df_rv = df_rv
 
-    def validate(self) -> None:
-        """Validate the random variable (no-op for this class)."""
-        pass
-
     def sample(self, n_groups: int, **kwargs: object) -> ArrayLike:
         """
         Sample group-level modes.

pyrenew/latent/infection_initialization_process.py

@@ -6,7 +6,7 @@
 from pyrenew.latent.infection_initialization_method import (
     InfectionInitializationMethod,
 )
-from pyrenew.metaclass import RandomVariable, _assert_type
+from pyrenew.metaclass import RandomVariable
 
 
 class InfectionInitializationProcess(RandomVariable):
@@ -33,37 +33,10 @@ def __init__(
         -------
         None
         """
-        InfectionInitializationProcess.validate(I_pre_init_rv, infection_init_method)
-
         super().__init__(name=name)
         self.I_pre_init_rv = I_pre_init_rv
         self.infection_init_method = infection_init_method
 
-    @staticmethod
-    def validate(
-        I_pre_init_rv: RandomVariable,
-        infection_init_method: InfectionInitializationMethod,
-    ) -> None:
-        """Validate the input arguments to the InfectionInitializationProcess class constructor
-
-        Parameters
-        ----------
-        I_pre_init_rv
-            A random variable representing the number of infections that occur at some time before the renewal process begins.
-        infection_init_method
-            An method to generate the initial infections.
-
-        Returns
-        -------
-        None
-        """
-        _assert_type("I_pre_init_rv", I_pre_init_rv, RandomVariable)
-        _assert_type(
-            "infection_init_method",
-            infection_init_method,
-            InfectionInitializationMethod,
-        )
-
     def sample(self) -> ArrayLike:
         """Sample the Infection Initialization Process.
 

pyrenew/latent/infections.py

@@ -60,10 +60,6 @@ def __init__(self, name: str) -> None:
         """
         super().__init__(name=name)
 
-    @staticmethod
-    def validate() -> None:  # numpydoc ignore=GL08
-        return None
-
     def sample(
         self,
         Rt: ArrayLike,

pyrenew/metaclass.py

@@ -10,35 +10,6 @@
 from numpyro.infer import MCMC, NUTS, Predictive, init_to_sample
 
 
-def _assert_type(arg_name: str, value: object, expected_type: type) -> None:
-    """
-    Matches TypeError arising during validation
-
-    Parameters
-    ----------
-    arg_name
-        Name of the argument
-    value
-        The object to be validated
-    expected_type
-        The expected object type
-
-    Raises
-    ------
-    TypeError
-        If `value` is not an instance of `expected_type`.
-
-    Returns
-    -------
-    None
-    """
-
-    if not isinstance(value, expected_type):
-        raise TypeError(
-            f"{arg_name} must be an instance of {expected_type}. Got {type(value)}"
-        )
-
-
 class RandomVariable(metaclass=ABCMeta):
     """
     Abstract base class for latent and observed random variables.
@@ -93,14 +64,6 @@ def sample(
         """
         pass
 
-    @staticmethod
-    @abstractmethod
-    def validate(**kwargs: object) -> None:
-        """
-        Validation of kwargs to be implemented in subclasses.
-        """
-        pass
-
     def __call__(self, **kwargs: object) -> tuple:
         """
         Alias for `sample`.
@@ -119,11 +82,6 @@ class Model(metaclass=ABCMeta):
     def __init__(self, **kwargs: object) -> None:  # numpydoc ignore=GL08
         pass
 
-    @staticmethod
-    @abstractmethod
-    def validate() -> None:  # numpydoc ignore=GL08
-        pass
-
     @abstractmethod
     def sample(
         self,

pyrenew/observation/base.py

@@ -36,7 +36,6 @@ class BaseObservationProcess(RandomVariable):
 
     Subclasses must implement:
 
-    - ``validate()``: Validate parameters (call ``_validate_pmf()`` for PMFs)
     - ``lookback_days()``: Return PMF length for initialization
     - ``infection_resolution()``: Return ``"aggregate"`` or ``"subpop"``
     - ``_predicted_obs()``: Transform infections to predicted values
@@ -79,22 +78,6 @@ def __init__(self, name: str, temporal_pmf_rv: RandomVariable) -> None:
         super().__init__(name=name)
         self.temporal_pmf_rv = temporal_pmf_rv
 
-    @abstractmethod
-    def validate(self) -> None:
-        """
-        Validate observation process parameters.
-
-        Subclasses must implement this method to validate all parameters.
-        Typically this involves calling ``_validate_pmf()`` for the PMF
-        and adding any additional parameter-specific validation.
-
-        Raises
-        ------
-        ValueError
-            If any parameters fail validation.
-        """
-        pass  # pragma: no cover
-
     @abstractmethod
     def lookback_days(self) -> int:
         """