Skip to content

Commit 58122e7

Browse files
authored
Cdc-ap66_fixing_badge_creation_typo_and_testing (#18)
* fixing typo and checking that it is running before merge to main * version bump * test * updating condition * fixing git push * Updated coverage badge * changed to "closed" action * run only on merge --------- Co-authored-by: cdc-ap66 <cdc-ap66@users.noreply.github.com>
1 parent 3a80454 commit 58122e7

4 files changed

Lines changed: 14 additions & 5 deletions

File tree

.github/workflows/run_qaqc.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ name: qaqc
22

33
on:
44
pull_request:
5-
types: [opened, reopened, synchronize, closed]
65
push:
76
branches: [main]
87

@@ -32,12 +31,16 @@ jobs:
3231
poetry run pytest
3332
3433
- name: Build badge
35-
if: ${{ github.event_name == 'pull_request' && github.envent.pull_request.type == 'closed' }}
34+
if: ${{ github.event.pull_request.merged == true }}
3635
run: |
3736
poetry run coverage-badge -f -o docs/assets/badges/coverage.svg
3837
echo '<!-- timestamp: '"$(date '+%Y-%m-%d %H:%M:%S')"' -->' >> docs/assets/badges/coverage.svg
3938
git config user.name "${{ github.actor }}"
4039
git config user.email "${{ github.actor }}@users.noreply.github.com"
4140
git add docs/assets/badges/coverage.svg
4241
git commit -m "Updated coverage badge"
43-
git push origin HEAD
42+
if [ -z "${{ github.head_ref }}" ]; then
43+
git push origin main
44+
else
45+
git push origin HEAD:${{ github.head_ref }}
46+
fi

changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ The versioning pattern is `YYYY.MM.DD.micro(a/b/{none if release})
88

99
---
1010

11+
## [2025.08.15.0a]
12+
13+
## Fixes
14+
15+
- Typo in QAQC github workflow and testing operation
16+
1117
## [2025.08.14.2a]
1218

1319
### Fixes

docs/assets/badges/coverage.svg

Lines changed: 1 addition & 1 deletion
Loading

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "cfa.dataops"
3-
version = "2025.08.14.2a"
3+
version = "2025.08.15.0a"
44
description = "Data cataloging, ETL, modeling, verification, and validation for CFA"
55
authors = [
66
{ name = "Phil Rogers", email = "ap66@cdc.gov" },

0 commit comments

Comments
 (0)