Skip to content

Documentation#11

Merged
swo merged 6 commits into
mainfrom
swo_docs
Aug 14, 2025
Merged

Documentation#11
swo merged 6 commits into
mainfrom
swo_docs

Conversation

@swo

@swo swo commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator

PR contents

  • Reduced Getting Started material in README.md to some limited examples on dataset listing & accessing
  • Moved all ETL running and new dataset creation information that was in README.md to the developer guide
  • Removed duplicated user guide that was at the bottom of the developer guide
  • Add support for mkdocs
    • Add CI: this will automatically serve/update the docs on GitHub Pages. See https://cdcgov.github.io/reedfrost/ for an example, including the API reference.
    • Put the filenames for example files into the code block title (see below for example)
image

Using mkdocs

To review this PR, you'll probably want to see the rendered docs. You'll need to build those locally; they get posted as artifacts only on landing the PR.

  • Install mkdocs dependencies with poetry install (they are just python packages that are in the poetry dependency group mkdocs)
  • Serve locally with poetry run mkdocs serve
  • Build a static local copy with poetry run mkdocs build

After landing this PR

Hopefully everything just works and the docs end up at <cdcgov.github.io/cfa-dataops>, although often I find I need to do 1-2 more commits to troubleshoot.

Open questions

  • What functions or objects should be in the API documentation?
  • Do you want to move any of the CLI functionality into different docs? E.g., the command line options that go with each workflow

@swo
swo requested review from cdc-ap66 and ryanraaschCDC August 13, 2025 20:21
@swo
swo marked this pull request as ready for review August 13, 2025 20:22

@cdc-ap66 cdc-ap66 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some amazing updates!. Thank you for going through the trouble to digest and update the docs, AND for adding the mkdocs generation. I can't wait to see the docs after they generate. I'd love to grab some time to show you some new features I have been working on and to get some of your ideas for where you see this evolving into. LGTM

Comment thread pyproject.toml Outdated
addopts = "--doctest-modules -vv --cov=cfa --cov-report html --cov-report term"
[project]
name = "cfa.dataops"
version = "2025.08.01.0a"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the version and consider copying your change summary to the changelog.md. One thing I usually do is add my summary to the changelog and then copy it into the PR description, adding screenshots and extra color, but keeping the bulk of it unchanged. example:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@swo
swo merged commit c0978e5 into main Aug 14, 2025
5 checks passed
@swo
swo deleted the swo_docs branch August 14, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants