Conversation
cdc-ap66
approved these changes
Aug 14, 2025
cdc-ap66
left a comment
Contributor
There was a problem hiding this comment.
These are some amazing updates!. Thank you for going through the trouble to digest and update the docs, AND for adding the mkdocs generation. I can't wait to see the docs after they generate. I'd love to grab some time to show you some new features I have been working on and to get some of your ideas for where you see this evolving into. LGTM
cdc-ap66
reviewed
Aug 14, 2025
| addopts = "--doctest-modules -vv --cov=cfa --cov-report html --cov-report term" | ||
| [project] | ||
| name = "cfa.dataops" | ||
| version = "2025.08.01.0a" |
Contributor
There was a problem hiding this comment.
please bump the version and consider copying your change summary to the changelog.md. One thing I usually do is add my summary to the changelog and then copy it into the PR description, adding screenshots and extra color, but keeping the bulk of it unchanged. example:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contents
README.mdto some limited examples on dataset listing & accessingREADME.mdto the developer guideUsing mkdocs
To review this PR, you'll probably want to see the rendered docs. You'll need to build those locally; they get posted as artifacts only on landing the PR.
poetry install(they are just python packages that are in the poetry dependency groupmkdocs)poetry run mkdocs servepoetry run mkdocs buildAfter landing this PR
Hopefully everything just works and the docs end up at <cdcgov.github.io/cfa-dataops>, although often I find I need to do 1-2 more commits to troubleshoot.
Open questions