-
Notifications
You must be signed in to change notification settings - Fork 1
Rr 114 expose metadata #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanraaschCDC
wants to merge
37
commits into
main
Choose a base branch
from
rr-114-expose-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
5fed98d
new function
ryanraaschCDC baacc44
get specific version
ryanraaschCDC 868562b
fix version name
ryanraaschCDC 5e2d39c
add print_version arg to get_dataframe()
ryanraaschCDC 9813723
add metadata to pd df
ryanraaschCDC a41d00d
add metadata functionality
ryanraaschCDC a835854
Merge branch 'main' of https://github.com/CDCgov/cfa-dataops into rr-…
ryanraaschCDC ef450d4
updates from main
ryanraaschCDC d5dfeca
Potential fix for pull request finding
ryanraaschCDC 462f8e4
Potential fix for pull request finding
ryanraaschCDC 1dca896
Fix lazy ndjson metadata handling
Copilot 9506bf6
Potential fix for pull request finding
ryanraaschCDC a0c6c1f
update docs
ryanraaschCDC 331ec40
Potential fix for pull request finding
ryanraaschCDC 725d5f6
update tests
ryanraaschCDC c213f6d
Potential fix for pull request finding
ryanraaschCDC 190a260
fix version spec
ryanraaschCDC 5f4297e
Merge branch 'rr-114-expose-metadata' of https://github.com/CDCgov/cf…
ryanraaschCDC 5082bf1
remove with_metadata"
ryanraaschCDC c9cad95
docs updates
ryanraaschCDC 42d6a51
update tests
ryanraaschCDC 6858a67
Merge branch 'main' of https://github.com/CDCgov/cfa-dataops into rr-…
ryanraaschCDC f4d2068
updates from main
ryanraaschCDC 47cfbc4
update changelog, pyproject
ryanraaschCDC 324c18e
create dataclass
ryanraaschCDC da80991
get version from _get_version_blobs
ryanraaschCDC 092404f
fix docs
ryanraaschCDC cd81530
use resolve_version in get_dataframe
ryanraaschCDC d4e9baa
Potential fix for pull request finding
ryanraaschCDC 2faa0df
Fix ledger version initialization
Copilot f2937c1
add version for ledger
ryanraaschCDC 80055a5
Merge branch 'rr-114-expose-metadata' of https://github.com/CDCgov/cf…
ryanraaschCDC 42e93ac
copilot fix
ryanraaschCDC d171de4
Potential fix for pull request finding
ryanraaschCDC 8567c26
Merge branch 'main' of https://github.com/CDCgov/cfa-dataops into rr-…
ryanraaschCDC c5647ab
doc updates for version string
ryanraaschCDC 3e6523d
Merge branch 'main' of https://github.com/CDCgov/cfa-dataops into rr-…
ryanraaschCDC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I feel like there is a lot of confusion introduced by the idea that a
versionmay be a string or a list of strings. Can we disambiguate troughout?Ideally, we decide either
I don't really see the utility of (1), but we currently support it throughout. Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanraaschCDC If this feels out of scope for the PR, feel free to move to an issue (or if you don't like the idea, feel free to not address it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably belongs in a separate issue I can address immediately after this PR merges. The only problem with going with #2 is that version_matcher() allows for
selection = "all", which is the only time a list of versions is returned. This functionality is not allowed for get_dataframe() so I think it would be possible to remove "all" from the selection, and just keep "newest" or "oldest" as options inselection.what do you think of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
selection = "all"isn't used anywhere in the codebase, then it could be removed! The other option would be to break the version resolver into two functions: one function returns "all" the versions that match the specification. Then a wrapper function chooses the newest or oldest.Then you clearly have one function that returns a list of a versions and one that returns a single version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can actually incorporate that change into this PR. It would make sense with the version metadata dataclass to have it sorted it out first. I'll remove the ability to select "all" so that
versionis always a string.