Patch badge#14
Closed
swo wants to merge 5 commits into
Closed
Conversation
cdc-ap66
reviewed
Aug 14, 2025
| steps: | ||
| - name: Build badge | ||
| run: | | ||
| poetry run coverage-badge -f -o docs/assets/badges/coverage.svg |
Contributor
There was a problem hiding this comment.
the one issue this might have is that the coverage badge is generating a badge using the coverage report from the testing run, which I don't think it will have access to if this is a different job.
Collaborator
Author
There was a problem hiding this comment.
Oh interesting. But where does the test result report get written?
My quick read is that coverage-badge calls Coverage.py, which in turn makes its own call to pytest? https://coverage.readthedocs.io/en/7.10.3/
Collaborator
Author
|
Closing in favor of #15 and other fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do
Solution 1: The badge only gets added when it's updated.
Solution 2: The badge gets committed once per pull to main. But then it has to happen after everything else, and not trigger versioning?
Done