Cdc-ap66_badge_ci_fix#15
Merged
Merged
Conversation
swo
reviewed
Aug 14, 2025
Comment on lines
+33
to
+40
| - name: Build badge | ||
| if: ${{ github.event_name == 'push' && github.ref_name == 'main' }} | ||
| run: | | ||
| poetry run coverage-badge -f -o docs/assets/badges/coverage.svg | ||
| echo '<!-- timestamp: '"$(date '+%Y-%m-%d %H:%M:%S')"' -->' >> docs/assets/badges/coverage.svg | ||
|
|
||
| - name: Check-in Coverage Badge | ||
| if: ${{ github.event_name == 'push' && github.ref_name == 'main' }} |
Collaborator
There was a problem hiding this comment.
Could be somewhat more elegant if this was one step, both building the badge and then checking it in
Contributor
Author
There was a problem hiding this comment.
I'll combine the steps
| - name: Check-in Coverage Badge | ||
| if: ${{ github.event_name == 'push' && github.ref_name == 'main' }} | ||
| run: | | ||
| if [ -z "${{ github.head_ref }}" ]; |
Collaborator
There was a problem hiding this comment.
Is this nominally doing the same thing as if: ${{ github.event_name == 'push' && github.ref_name == 'main' }}? Honest question born of ignorance
Contributor
Author
There was a problem hiding this comment.
looks the same to me. I just copied it from yours.
Contributor
Author
There was a problem hiding this comment.
ooooh, I see what you mean. I didn't need any of this anymore.. it's gone
swo
self-requested a review
August 14, 2025 19:49
swo
approved these changes
Aug 14, 2025
swo
left a comment
swo
left a comment
Collaborator
There was a problem hiding this comment.
Hopefully this fixes the CI failure caused by poetry not being installed!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2025.08.14.1a]
Fixes
steps skipped in ci for PR