Skip to content

cdc-ap66_fix_push_HEAD#17

Merged
cdc-ap66 merged 5 commits into
mainfrom
cdc-ap66_fix_push_HEAD
Aug 14, 2025
Merged

cdc-ap66_fix_push_HEAD#17
cdc-ap66 merged 5 commits into
mainfrom
cdc-ap66_fix_push_HEAD

Conversation

@cdc-ap66

Copy link
Copy Markdown
Contributor

[2025.08.14.2a]

Fixes

  • Iteration on last update since main is the default branch only needs to push to HEAD (not HEAD:)
  • Changing condition to on pull_request closure instead of push to main

@cdc-ap66
cdc-ap66 requested a review from swo August 14, 2025 21:17
@cdc-ap66 cdc-ap66 changed the title Cdc-ap66_fix_push_HEAD cdc-ap66_fix_push_HEAD Aug 14, 2025

@swo swo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this to run when a PR is closed? That seems a bit weird: like, if I open a junk PR, and then close it, then why should we update the badge on main?

I would think to run this job only on push: branches: [main]

But I'm approving just so you can land if you want to!

@cdc-ap66

Copy link
Copy Markdown
Contributor Author

Do you want this to run when a PR is closed? That seems a bit weird: like, if I open a junk PR, and then close it, then why should we update the badge on main?

I would think to run this job only on push: branches: [main]

But I'm approving just so you can land if you want to!

yeah, I get that this is a possible case where we run testing on a closed PR that doesn't result on a merge, but a merge is also a closure and that is the case I an going for here to see if it avoids my branch rules, not merging directly to main on push (like run just before the push?) I don't actually know if this is the case, but I though I'd give it a try

@cdc-ap66
cdc-ap66 merged commit 3a80454 into main Aug 14, 2025
4 checks passed
@cdc-ap66
cdc-ap66 deleted the cdc-ap66_fix_push_HEAD branch August 18, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants