cdc-ap66_fix_push_HEAD#17
Conversation
swo
left a comment
There was a problem hiding this comment.
Do you want this to run when a PR is closed? That seems a bit weird: like, if I open a junk PR, and then close it, then why should we update the badge on main?
I would think to run this job only on push: branches: [main]
But I'm approving just so you can land if you want to!
yeah, I get that this is a possible case where we run testing on a closed PR that doesn't result on a merge, but a merge is also a closure and that is the case I an going for here to see if it avoids my branch rules, not merging directly to main on push (like run just before the push?) I don't actually know if this is the case, but I though I'd give it a try |
[2025.08.14.2a]
Fixes