[WORKAROUND] Traditional schedule for e assets, eager for h* assets#1060
Conversation
… automation conditions on
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
+ Coverage 58.44% 60.80% +2.35%
==========================================
Files 28 32 +4
Lines 1918 2064 +146
==========================================
+ Hits 1121 1255 +134
- Misses 797 809 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a temporary Dagster workaround to keep weekly forecast assets running automatically while custom automation-condition behavior is being debugged. It replaces the prior “upstream” automation-condition approach for the initial e assets with a fixed-time schedule, and sets h* assets to run eagerly under an automation-condition sensor.
Changes:
- Commented out the custom
IsWeekdayautomation condition and theWeeklyForecastUpstreamautomation sensor. - Added a
weekly_forecast_e_scheduleto trigger the initial e-asset materializations on a cron. - Set
pyrenew_h/pyrenew_heautomation conditions toeager()and added an automation-condition sensor for theWeeklyForecastHgroup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
giomrella
left a comment
There was a problem hiding this comment.
Looks good besides the change to EpiAutoGP, which seems like an accidental inclusion
There was a problem hiding this comment.
This seems unintentional
There was a problem hiding this comment.
It's a pre-commit change.
There was a problem hiding this comment.
working on getting julia added to pre-commit.ci so this doesn't happen pre-commit-ci/runner-image#332
This creates a schedule that submits run requests 30 minutes after the upstream
cfa-nssp-etlasset is materializing for the initial e assets. This temporarily disables their "automation conditions".It also sets the initial
h*assets' automation conditions toeager(), as the upstreamnhsn_hrd_prelimis already gated to Wednesdays.