Commit 7e62e13
authored
Refactoring augmentation-lambda persistence id assignment (#610)
## Description
This PR is intended to try to clean up and streamline _process_record so
that the logic for when and how we fall back to original EICR cleaner. I
personally find the currently written process a bit tough to follow and
am hoping this will help clarify.
## Related Issues
## Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING
--------------------->
## Checklist
Please review and complete the following checklist before submitting
your pull request:
- [ ] I have ensured that the pull request is of a manageable size,
allowing it to be reviewed within a single session.
- [ ] I have reviewed my changes to ensure they are clear, concise, and
well-documented.
- [ ] I have updated the documentation, if applicable.
- [ ] I have added or updated test cases to cover my changes, if
applicable.
- [ ] I have minimized the number of reviewers to include only those
essential for the review.
## Checklist for Reviewers
Please review and complete the following checklist during the review
process:
- [ ] The code follows best practices and conventions.
- [ ] The changes implement the desired functionality or fix the
reported issue.
- [ ] The tests cover the new changes and pass successfully.
- [ ] Any potential edge cases or error scenarios have been considered.1 parent de6d091 commit 7e62e13
18 files changed
Lines changed: 397 additions & 391 deletions
File tree
- e2e/snapshots/test_e2e/test_upload_and_process
- patient_alliance
- sample9
- packages
- augmentation-lambda
- src/augmentation_lambda
- tests
- snapshots/test_augmentation_lambda_function
- test_handler_writes_original_eicr_when_ttc_output_is_passthrough
- test_handler_writes_original_eicr_when_ttc_output_passthrough_reason_is_missing
- text-to-code-lambda
- src/text_to_code_lambda
- tests/snapshots/test_lambda_function
- test_handler_adds_unmatched_error_when_selected_candidate_has_no_opensearch_hits
- test_handler_continues_when_selected_candidate_is_none
- test_handler_malformed_eicr_with_no_schematron_issues
- test_handler_reranker_returns_empty
- test_handler_saves_metadata_when_no_relevant_schematron_fields
- test_handler_success
- test_handler_writes_ttc_exception_passthrough_output_when_record_exception_has_recoverable_persistence_id
- validation/tests
Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 0 additions & 137 deletions
This file was deleted.
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
0 commit comments