Skip to content

Commit 7e62e13

Browse files
Refactoring augmentation-lambda persistence id assignment (#610)
## Description This PR is intended to try to clean up and streamline _process_record so that the logic for when and how we fall back to original EICR cleaner. I personally find the currently written process a bit tough to follow and am hoping this will help clarify. ## Related Issues ## Additional Notes [Add any additional context or notes that reviewers should know about.] <--------------------- REMOVE THE LINES BELOW BEFORE MERGING ---------------------> ## Checklist Please review and complete the following checklist before submitting your pull request: - [ ] I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session. - [ ] I have reviewed my changes to ensure they are clear, concise, and well-documented. - [ ] I have updated the documentation, if applicable. - [ ] I have added or updated test cases to cover my changes, if applicable. - [ ] I have minimized the number of reviewers to include only those essential for the review. ## Checklist for Reviewers Please review and complete the following checklist during the review process: - [ ] The code follows best practices and conventions. - [ ] The changes implement the desired functionality or fix the reported issue. - [ ] The tests cover the new changes and pass successfully. - [ ] Any potential edge cases or error scenarios have been considered.
1 parent de6d091 commit 7e62e13

18 files changed

Lines changed: 397 additions & 391 deletions

File tree

e2e/snapshots/test_e2e/test_upload_and_process/augmentation_metadata.json

Lines changed: 0 additions & 22 deletions
This file was deleted.

e2e/snapshots/test_e2e/test_upload_and_process/augmented_eicr.xml

Lines changed: 0 additions & 137 deletions
This file was deleted.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
2-
"augmented_eicr_id": "1.2.840.113619.21.1.139060385287897942.5.3",
2+
"augmented_eicr_id": "1.2.840.113619.21.1.139060385287897942.5.3^1899729054011780",
33
"error": "Unable to find tag in eICR document for XPath: /ClinicalDocument/setId",
44
"nonstandard_codes": [],
5-
"original_eicr_id": "1.2.840.113619.21.1.139060385287897942.5.3",
5+
"original_eicr_id": "1.2.840.113619.21.1.139060385287897942.5.3^1899729054011780",
66
"passthrough": true,
77
"passthrough_reason": "augmentation_exception"
88
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
2-
"augmented_eicr_id": "2025/09/03/1-5f84c7a5-91d7f5c6a2b7c9e08f0d1234",
2+
"augmented_eicr_id": "1.2.840.114350.1.13.370.2.7.8.688883.608381234",
33
"error": null,
44
"nonstandard_codes": [],
5-
"original_eicr_id": "2025/09/03/1-5f84c7a5-91d7f5c6a2b7c9e08f0d1234",
5+
"original_eicr_id": "1.2.840.114350.1.13.370.2.7.8.688883.608381234",
66
"passthrough": true,
77
"passthrough_reason": "no_relevant_schematron_errors"
88
}

0 commit comments

Comments
 (0)