refactor: Move some log statements closer to relevant code#578
Open
JNygaard-Skylight wants to merge 1 commit into
Open
refactor: Move some log statements closer to relevant code#578JNygaard-Skylight wants to merge 1 commit into
JNygaard-Skylight wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 90.85% 90.87% +0.01%
==========================================
Files 50 50
Lines 2691 2695 +4
==========================================
+ Hits 2445 2449 +4
Misses 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JNygaard-Skylight
requested review from
BradySkylight,
bamader,
nickclyde and
robertandremitchell
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are several log statements in the TTC lambda function that could be moved into their relevant modules:
"Evaluating candidates and selecting relevant text for each error in the eICR"can be moved into the embedder"Evaluating candidates and selecting relevant text"can be moved into the evaluator.Related Issues
Closes # n/a
Additional Notes
This was something I ended up doing for PR 570 to reduce the size of the
_process_schematron_errorsfunction. However it can be easily moved into its own PR.