Extending ty checks to most of packages/ folder#580
Open
robertandremitchell wants to merge 4 commits into
Open
Extending ty checks to most of packages/ folder#580robertandremitchell wants to merge 4 commits into
robertandremitchell wants to merge 4 commits into
Conversation
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 50 50
Lines 2691 2691
=======================================
Hits 2445 2445
Misses 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
tytyping checks to the test suite as best practices recommend. I am going to try to tackledata_curationin a separate ticket because there are 220 typing violations there, so it's a bigger lift to get resolved. Similarly, there's a handful of non-package updates, about 70, that'd we need to make, but because they involve the azure scripts and other files we questionably no longer need I am not sure if they're worth the lift, so I'll also draft up some exclusion files.I instead focused on the other
packages/ande2e/. Work on the rest of repo continues here: https://app.zenhub.com/workspaces/dibbs-text-to-code-68756bf8ea06bb00319391c0/issues/gh/cdcgov/dibbs-text-to-code/579Related Issues
Closes #573
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: