Skip to content

Extending ty checks to most of packages/ folder#580

Open
robertandremitchell wants to merge 4 commits into
mainfrom
rob/573-typing-in-tests
Open

Extending ty checks to most of packages/ folder#580
robertandremitchell wants to merge 4 commits into
mainfrom
rob/573-typing-in-tests

Conversation

@robertandremitchell
Copy link
Copy Markdown
Collaborator

@robertandremitchell robertandremitchell commented May 26, 2026

Description

Extends ty typing checks to the test suite as best practices recommend. I am going to try to tackle data_curation in a separate ticket because there are 220 typing violations there, so it's a bigger lift to get resolved. Similarly, there's a handful of non-package updates, about 70, that'd we need to make, but because they involve the azure scripts and other files we questionably no longer need I am not sure if they're worth the lift, so I'll also draft up some exclusion files.

I instead focused on the other packages/ and e2e/. Work on the rest of repo continues here: https://app.zenhub.com/workspaces/dibbs-text-to-code-68756bf8ea06bb00319391c0/issues/gh/cdcgov/dibbs-text-to-code/579

Related Issues

Closes #573

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@robertandremitchell robertandremitchell linked an issue May 26, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.85%. Comparing base (3a0500d) to head (d05015a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          50       50           
  Lines        2691     2691           
=======================================
  Hits         2445     2445           
  Misses        246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robertandremitchell robertandremitchell marked this pull request as ready for review May 26, 2026 20:33
@robertandremitchell robertandremitchell changed the title Extending ty checks to entire packages/ folder Extending ty checks to most of packages/ folder May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing in Tests

2 participants