Merge pull request #742 from CDLUC3/bug/228/JS-prevent-removal-of-a-primary-collaborator

Return an error when trying to remove a Primary collaborator

Author: jupiter007

CHANGELOG.md

@@ -84,6 +84,7 @@
 - added data-migration to fix question JSON so that `"selected": 0` is now `"selected": false` (and `1` -> `true`).
 
 ### Updated
+- Updated `removeProjectCollaborator` to return error when trying to remove a `Primary` collaborator, since there always has to be one `Primary` [#228]
 - Updated dependencies flagged by dependabot and renovate.
 - Updated jest and @dmptool dependencies.
 - Updated `saveMaDMPVersion` function to include a `dmpId` argument and to properly convert the app name to a maDMP acceptable format

src/resolvers/collaborator.ts

@@ -330,6 +330,13 @@ export const resolvers: Resolvers = {
 
         // If the user has permission on the Project
         if (await hasPermissionOnProject(context, project)) {
+          if (projectCollaborator.accessLevel === ProjectCollaboratorAccessLevel.PRIMARY) {
+            // Cannot remove a collaborator that has PRIMARY access, they must be demoted first
+            if (!projectCollaborator.errors['general']) {
+              projectCollaborator.addError('general', 'Cannot remove a collaborator that has PRIMARY access level');
+            }
+            return projectCollaborator;
+          }
           return await projectCollaborator.delete(context);
         }