Chore/229/js update javascript dependencies#792
Open
jupiter007 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229
I ran
yarn auditinitially and found 43 vulnerabilities (2 Critical, 22 High, 16 Moderate, and 3 Low).After update dependencies, there was only one vulnerability listed at
Moderateand that was forbootstrap. We cannot updatebootstrapthough because that would require tons of code changes or a detailed polyfill. I tried to create one, but it got really involved, so I stopped.package.jsonandyarn.lockto address security vulnerabilities.Upload Plansection, because validation was always requiring aurlchrome-headless-shellsince we already installchromiumviaapt-getjavscript/src/utils/accordion.jsandviews/phases/_guidances_notes.html.erbdue to package updates.controllers/contributors_controller.rbbecause after editing contributor info, the panel didn't change back to the table view.