Register Watchpoints#532
Merged
Merged
Conversation
Sightem
force-pushed
the
reg-watchpoints
branch
from
ffc23bd to
631764d
Compare
Sightem
force-pushed
the
reg-watchpoints
branch
from
c67bcbc to
0f594cc
Compare
Sightem
force-pushed
the
reg-watchpoints
branch
from
0f594cc to
ffb4033
Compare
Member
|
I guess we have to figure out how we can benchmark this properly, now 😅 |
Member
|
@calc84maniac suggested using https://github.com/TheScienceElf/TI-84-CE-Raytracing as a benchmark, and after a few opts with the likely/unlikely macros, emulation speed reported by @Sightem is at ≈660%, while master is at ≈670%, approximately 1.5% slower now. On my side, it's at ≈980% during the first half of the drawing on master, and ≈965% on this branch. Also about 1.5% slower. Looks like the impact is very small :) Good job, merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements register watchpoints.