Skip to content

Commit 5ea233a

Browse files
committed
basis - add note about order for ApplyAtPoints
1 parent 3778dba commit 5ea233a

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

interface/ceed-basis.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,6 +1593,7 @@ int CeedBasisApplyAtPoints(CeedBasis basis, CeedInt num_points, CeedTransposeMod
15931593
for (CeedInt p = 0; p < num_points; p++) {
15941594
CeedInt pre = num_comp * CeedIntPow(Q_1d, dim - 1), post = 1;
15951595

1596+
// Note: stepping "backwards" through the tensor contractions to agree with the ordering of the Chebyshev coefficients
15961597
for (CeedInt d = dim - 1; d >= 0; d--) {
15971598
// ------ Tensor contract with current Chebyshev polynomial values
15981599
CeedCall(CeedChebyshevPolynomialsAtPoint(x_array_read[p * dim + d], Q_1d, chebyshev_x));
@@ -1609,6 +1610,7 @@ int CeedBasisApplyAtPoints(CeedBasis basis, CeedInt num_points, CeedTransposeMod
16091610

16101611
// ---- Values at point
16111612
for (CeedInt p = 0; p < num_points; p++) {
1613+
// Note: stepping "backwards" through the tensor contractions to agree with the ordering of the Chebyshev coefficients
16121614
// Dim**2 contractions, apply grad when pass == dim
16131615
for (CeedInt pass = dim - 1; pass >= 0; pass--) {
16141616
CeedInt pre = num_comp * CeedIntPow(Q_1d, dim - 1), post = 1;
@@ -1653,6 +1655,7 @@ int CeedBasisApplyAtPoints(CeedBasis basis, CeedInt num_points, CeedTransposeMod
16531655
for (CeedInt p = 0; p < num_points; p++) {
16541656
CeedInt pre = num_comp * 1, post = 1;
16551657

1658+
// Note: stepping "backwards" through the tensor contractions to agree with the ordering of the Chebyshev coefficients
16561659
for (CeedInt d = dim - 1; d >= 0; d--) {
16571660
// ------ Tensor contract with current Chebyshev polynomial values
16581661
CeedCall(CeedChebyshevPolynomialsAtPoint(x_array_read[p * dim + d], Q_1d, chebyshev_x));

0 commit comments

Comments
 (0)