Fix edge case in offset padding for empty cells#1800
Merged
Conversation
Member
|
Something is wrong with GitHub's mac image |
Member
|
Ok, give the pipelines some time, but I'll merge this fix to main in a sec and you can rebase: #1801 Edit: Ok, good to rebase and CI should be fixed |
zatkins-dev
force-pushed
the
zach/points-offsets-bug
branch
from
76c9e69 to
8c76f87
Compare
jeremylt
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a weird edge case where if the first cell is empty, then the offset for all points is out of bounds.