Skip to content

Add support for fully assembling operators with multiple active fields with different bases #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zatkins-dev merged 7 commits into from
Apr 30, 2026
Merged

Add support for fully assembling operators with multiple active fields with different bases #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fda4f5
op: Add support for fully assembling operators with multiple active f…
zatkins-dev Apr 15, 2026
60458c5
cuda: Add support for constexpr array compilation inputs
zatkins-dev Apr 24, 2026
04e37af
gpu/cuda/ref: mixed field assembly support
zatkins-dev Apr 16, 2026
24a5aa4
tests: Add multi-basis assembly tests
zatkins-dev Apr 17, 2026
0510210
gen: use fallback operator for oriented elem restrictions/bases
zatkins-dev Apr 28, 2026
49c8696
tests: add operator assembly tests for non-trivial oriented restrictions
zatkins-dev Apr 28, 2026
5388e7c
gpu/hip/ref: add support for mixed basis assembly
zatkins-dev Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Specifically, directories set with `CeedAddJitSourceRoot(ceed, "foo/bar")` will
- Added support to code generation backends `/gpu/cuda/gen` and `/gpu/hip/gen` for operators with both tensor and non-tensor bases.
- Add `CeedGetGitVersion()` to access the Git commit and dirty state of the repository at build time.
- Add `CeedGetBuildConfiguration()` to access compilers, flags, and related information about the build environment.
- Add support for full `CeedOperator` assembly for operators with multiple active fields with different bases for CPU backends and `/gpu/cuda/ref` and `/gpu/hip/gen` backends.

### Examples

Expand Down
43 changes: 24 additions & 19 deletions backends/cuda-gen/ceed-cuda-gen-operator-build.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,10 @@ static int CeedOperatorBuildKernelFieldData_Cuda_gen(std::ostringstream &code, C
break;
case CEED_EVAL_WEIGHT:
break; // No action
// LCOV_EXCL_START
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
CeedCallBackend(CeedBasisDestroy(&basis));
return CEED_ERROR_SUCCESS;
Expand Down Expand Up @@ -459,11 +458,10 @@ static int CeedOperatorBuildKernelRestriction_Cuda_gen(std::ostringstream &code,
data->indices.inputs[i] = (CeedInt *)rstr_data->d_offsets;
break;
}
// LCOV_EXCL_START
case CEED_RESTRICTION_ORIENTED:
case CEED_RESTRICTION_CURL_ORIENTED:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
} else {
Expand Down Expand Up @@ -511,11 +509,10 @@ static int CeedOperatorBuildKernelRestriction_Cuda_gen(std::ostringstream &code,
case CEED_RESTRICTION_POINTS:
data->indices.outputs[i] = (CeedInt *)rstr_data->d_offsets;
break;
// LCOV_EXCL_START
case CEED_RESTRICTION_ORIENTED:
case CEED_RESTRICTION_CURL_ORIENTED:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
CeedCallBackend(CeedElemRestrictionDestroy(&elem_rstr));
Expand Down Expand Up @@ -630,11 +627,10 @@ static int CeedOperatorBuildKernelBasis_Cuda_gen(std::ostringstream &code, CeedO
}
break;
}
// LCOV_EXCL_START
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
} else {
switch (eval_mode) {
Expand Down Expand Up @@ -692,10 +688,11 @@ static int CeedOperatorBuildKernelBasis_Cuda_gen(std::ostringstream &code, CeedO
// LCOV_EXCL_START
case CEED_EVAL_WEIGHT:
break; // Should not occur
// LCOV_EXCL_STOP
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
CeedCallBackend(CeedBasisDestroy(&basis));
Expand Down Expand Up @@ -762,11 +759,10 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
break;
case CEED_EVAL_WEIGHT:
break;
// LCOV_EXCL_START
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}

Expand Down Expand Up @@ -815,11 +811,10 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
code << tab << "CeedScalar r_s" << var_suffix << "[1];\n";
code << tab << "r_s" << var_suffix << "[0] = 1.0;\n";
break;
// LCOV_EXCL_START
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
code << "\n";
Expand All @@ -845,10 +840,11 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
// LCOV_EXCL_START
case CEED_EVAL_WEIGHT:
break; // Should not occur
// LCOV_EXCL_STOP
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}

Expand Down Expand Up @@ -926,11 +922,10 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
code << tab << "CeedScalar r_s" << var_suffix << "[1];\n";
code << tab << "r_s" << var_suffix << "[0] = r_q" << var_suffix << "[q];\n";
break;
// LCOV_EXCL_START
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
code << "\n";
Expand All @@ -956,10 +951,11 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
// LCOV_EXCL_START
case CEED_EVAL_WEIGHT:
break; // Should not occur
// LCOV_EXCL_STOP
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
} else {
Expand Down Expand Up @@ -1072,10 +1068,11 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
// LCOV_EXCL_START
case CEED_EVAL_WEIGHT:
break; // Should not occur
// LCOV_EXCL_STOP
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
} else if (use_3d_slices) {
Expand Down Expand Up @@ -1114,10 +1111,11 @@ static int CeedOperatorBuildKernelQFunction_Cuda_gen(std::ostringstream &code, C
// LCOV_EXCL_START
case CEED_EVAL_WEIGHT:
break; // Should not occur
// LCOV_EXCL_STOP
case CEED_EVAL_DIV:
case CEED_EVAL_CURL:
data->use_fallback = true;
break; // TODO: Not implemented
// LCOV_EXCL_STOP
}
}
}
Expand Down Expand Up @@ -1222,6 +1220,13 @@ extern "C" int CeedOperatorBuildKernel_Cuda_gen(CeedOperator op, bool *is_good_b
CeedCallBackend(CeedOperatorBuildKernelData_Cuda_gen(ceed, num_input_fields, op_input_fields, qf_input_fields, num_output_fields,
op_output_fields, qf_output_fields, &max_P, &max_P_1d, &Q, &Q_1d, &max_dim, &is_all_tensor,
&use_3d_slices));
if (data->use_fallback) {
*is_good_build = false;
CeedCallBackend(CeedOperatorSetSetupDone(op));
CeedCallBackend(CeedDestroy(&ceed));
CeedCallBackend(CeedQFunctionDestroy(&qf));
return CEED_ERROR_SUCCESS;
}
data->max_P_1d = is_all_tensor ? max_P_1d : max_P;
}
if (is_at_points) {
Expand Down
Loading
Loading