Skip to content

Commit 454d34f

Browse files
committed
[feat] 읽기 전용, 쓰기 전용 분리
1 parent 8aa467b commit 454d34f

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

src/main/java/ceos/backend/domain/application/helper/ApplicationHelper.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,15 @@ public void sendSlackUnableReasonMessage(
4949
}
5050

5151
public Application getApplicationById(Long id) {
52+
return applicationRepository
53+
.findById(id)
54+
.orElseThrow(
55+
() -> {
56+
throw ApplicantNotFound.EXCEPTION;
57+
});
58+
}
5259

60+
public Application getApplicationByIdForUpdate(Long id) {
5361
return applicationRepository
5462
.findByIdWithPessimisticLock(id)
5563
.orElseThrow(

src/main/java/ceos/backend/domain/application/service/ApplicationService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ public GetInterviewTime getInterviewTime(Long applicationId) {
237237
public void updateInterviewTime(Long applicationId, UpdateInterviewTime updateInterviewTime) {
238238
recruitmentValidator.validateBetweenStartDateDocAndResultDateDoc(); // 기간 검증
239239
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증
240-
final Application application = applicationHelper.getApplicationById(applicationId);
240+
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
241241
applicationValidator.validateDocumentPassStatus(application); // 서류 통과 검증
242242
final List<Interview> interviews = interviewRepository.findAll();
243243
final String duration =
@@ -262,15 +262,15 @@ public void updateDocumentPassStatus(Long applicationId, UpdatePassStatus update
262262
recruitmentValidator.validateBetweenStartDateDocAndResultDateDoc(); // 기간 검증
263263
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증
264264

265-
final Application application = applicationHelper.getApplicationById(applicationId);
265+
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
266266
application.updateDocumentPass(updatePassStatus.getPass());
267267
}
268268

269269
@Transactional
270270
public void updateFinalPassStatus(Long applicationId, UpdatePassStatus updatePassStatus) {
271271
recruitmentValidator.validateBetweenResultDateDocAndResultDateFinal(); // 기간 검증
272272
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증
273-
final Application application = applicationHelper.getApplicationById(applicationId);
273+
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
274274
applicationValidator.validateDocumentPassStatus(application); // 서류 통과 검증
275275

276276
application.updateFinalPass(updatePassStatus.getPass());

0 commit comments

Comments
 (0)