[23기_임종훈] 성능최적화 미션 제출합니다.#74
Open
Jong0128 wants to merge 2 commits into
Open
Conversation
fervovita
reviewed
May 24, 2026
| </details> | ||
|
|
||
| <details> | ||
| <summary> <h2> 성능 최적화 </h2> </summary> |
There was a problem hiding this comment.
리드미에 성능 최적화 과정을 수치와 함께 작성해 주셔서 도움 많이 되었습니다👍
|
|
||
| @Override | ||
| @Transactional | ||
| public OrderResponse cancelOrder(Long userId, Long orderId) { |
There was a problem hiding this comment.
cancelOrder 부분도 외부 API 호출(paymentService.cancel)이 @Transactional로 묶여 있어서 외부 API 호출 시간 동안 DB 커넥션을 잡고 있을 것 같아요.
이 부분도 createOrder처럼 추후에 트랜잭션을 분리해 주시면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.