fix calling update only when data is invalidated

Author: ChrLackner

ngsolve_webgpu/cf.py

@@ -211,6 +211,7 @@ class FunctionData:
     order: int
     order_3d: int
     _timestamp: float = -1
+    _gpu_dirty: bool = True
     minval: list[float]
     maxval: list[float]
 
@@ -257,6 +258,7 @@ def update(self, options: RenderOptions):
         self._timestamp = options.timestamp
         self.mesh_data.update(options)
         self._create_data()
+        self._gpu_dirty = True
 
     @property
     def needs_update(self) -> bool:
@@ -334,19 +336,21 @@ def get_buffers(self, include_mesh_data=True):
             buffers = self.mesh_data.get_buffers().copy()
         else:
             buffers = {}
-
         if self.data_2d is not None:
-            self.gpu_2d = buffer_from_array(
-                self.data_2d, label="function_data_2d", reuse=self.gpu_2d
-            )
+            if self._gpu_dirty or self.gpu_2d is None:
+                self.gpu_2d = buffer_from_array(
+                    self.data_2d, label="function_data_2d", reuse=self.gpu_2d
+                )
             buffers["data_2d"] = self.gpu_2d
 
         if self.data_3d is not None:
-            self.gpu_3d = buffer_from_array(
-                self.data_3d, label="function_data_3d", reuse=self.gpu_3d
-            )
+            if self._gpu_dirty or self.gpu_3d is None:
+                self.gpu_3d = buffer_from_array(
+                    self.data_3d, label="function_data_3d", reuse=self.gpu_3d
+                )
             buffers["data_3d"] = self.gpu_3d
-            self._need_gpu_update = False
+
+        self._gpu_dirty = False
 
         return buffers
 
@@ -1093,6 +1097,8 @@ def redraw(self, timestamp=None):
 
     def update(self, options: RenderOptions):
         self.options = options
+        if not self.needs_update:
+            return
         bb = self.mesh.ngmesh.bounding_box
         self.bounding_box = np.array(
             [[bb[0][0], bb[0][1], bb[0][2]], [bb[1][0], bb[1][1], bb[1][2]]]
@@ -1171,6 +1177,9 @@ def update(self, options):
         import numpy as np
         from ngsolve.webgui import FieldLines
 
+        if not self.needs_update:
+            return
+
         if self.seed is not None:
             np.random.seed(self.seed)
         data = FieldLines(self.cf, self.start_region, **self.fieldline_options)

ngsolve_webgpu/facet_cf.py

@@ -194,14 +194,15 @@ def update(self, options: RenderOptions):
         self.n_instances = data.n_edges
         self.n_vertices = 2 * (self.subdivision + 1)
 
-        self._buffers["geometry"] = buffer_from_array(
-            data.geometry_buffer, label="facet_geometry",
-            reuse=self._buffers.get("geometry"),
-        )
-        self._buffers["values"] = buffer_from_array(
-            data.function_buffer, label="facet_values",
-            reuse=self._buffers.get("values"),
-        )
+        if self.needs_update or "geometry" not in self._buffers:
+            self._buffers["geometry"] = buffer_from_array(
+                data.geometry_buffer, label="facet_geometry",
+                reuse=self._buffers.get("geometry"),
+            )
+            self._buffers["values"] = buffer_from_array(
+                data.function_buffer, label="facet_values",
+                reuse=self._buffers.get("values"),
+            )
         self._buffers["subdivision"] = uniform_from_array(
             np.array([self.subdivision], dtype=np.uint32),
             label="facet_subdivision",
@@ -324,9 +325,10 @@ def update(self, options: RenderOptions):
                 self.active = False
                 return
 
-        self._facet_gpu = buffer_from_array(
-            self._facet_data, label="facet_values_3d", reuse=self._facet_gpu
-        )
+        if self.needs_update or self._facet_gpu is None:
+            self._facet_gpu = buffer_from_array(
+                self._facet_data, label="facet_values_3d", reuse=self._facet_gpu
+            )
 
         self.shader_defines["FACET_CF"] = "1"
         self.shader_defines["MAX_EVAL_ORDER"] = max(

ngsolve_webgpu/vectors.py

@@ -71,6 +71,7 @@ def __init__(
         scale_by_value: bool = False,
     ):
         self.u_nvectors = None
+        self._last_data_ts = None
         self.clipping = clipping or Clipping()
         self.function_data = function_data
         self.scale_by_value = scale_by_value
@@ -298,6 +299,10 @@ def _expand_vectors_for_symmetry(self):
     def update(self, options):
         self.function_data.update(options)
         self._complex_settings.update(options)
+        dirty = self.needs_update or self._last_data_ts != self.function_data._timestamp
+        if not dirty:
+            return
+        self._last_data_ts = self.function_data._timestamp
         self.compute_vectors()
         is_complex = self.function_data.cf.is_complex
         max_val = self.function_data.maxval[0]