cache textures and views to prevent roundtrips in frame rendering

Author: ChrLackner

webgpu/canvas.py

@@ -235,11 +235,16 @@ class Canvas:
     device: Device
     depth_format: TextureFormat
     depth_texture: Texture = None
+    depth_texture_view = None
     multisample_texture: Texture = None
+    multisample_texture_view = None
     multisample: MultisampleState = None
     target_texture: Texture = None
+    target_texture_view = None
     select_depth_texture: Texture = None
+    select_depth_texture_view = None
     select_texture: Texture = None
+    select_texture_view = None
 
     width: int = 0
     height: int = 0
@@ -389,6 +394,11 @@ def destroy_textures(self):
             ]:
                 if tex is not None:
                     tex.destroy()
+            self.target_texture_view = None
+            self.multisample_texture_view = None
+            self.depth_texture_view = None
+            self.select_texture_view = None
+            self.select_depth_texture_view = None
 
     @debounce(5)
     def resize(self):
@@ -434,6 +444,9 @@ def resize(self):
                     usage=TextureUsage.RENDER_ATTACHMENT,
                     label="multisample",
                 )
+                self.multisample_texture_view = self.multisample_texture.createView()
+            else:
+                self.multisample_texture_view = None
 
             self.depth_texture = device.createTexture(
                 size=[width, height, 1],
@@ -442,6 +455,7 @@ def resize(self):
                 label="depth_texture",
                 sampleCount=self.multisample.count,
             )
+            self.depth_texture_view = self.depth_texture.createView()
 
             self.target_texture_view = self.target_texture.createView()
 
@@ -458,6 +472,7 @@ def resize(self):
                 label="select_depth",
             )
             self.select_texture_view = self.select_texture.createView()
+            self.select_depth_texture_view = self.select_depth_texture.createView()
 
             self.width = width
             self.height = height
@@ -470,7 +485,7 @@ def color_attachments(self, loadOp: LoadOp):
         return [
             RenderPassColorAttachment(
                 view=(
-                    self.multisample_texture.createView()
+                    self.multisample_texture_view
                     if have_multisample
                     else self.target_texture_view
                 ),
@@ -491,14 +506,14 @@ def select_attachments(self, loadOp: LoadOp):
 
     def select_depth_stencil_attachment(self, loadOp: LoadOp):
         return RenderPassDepthStencilAttachment(
-            self.select_depth_texture.createView(),
+            self.select_depth_texture_view,
             depthClearValue=1.0,
             depthLoadOp=loadOp,
         )
 
     def depth_stencil_attachment(self, loadOp: LoadOp):
         return RenderPassDepthStencilAttachment(
-            self.depth_texture.createView(),
+            self.depth_texture_view,
             depthClearValue=1.0,
             depthLoadOp=loadOp,
         )

webgpu/scene.py

@@ -310,6 +310,8 @@ def __on_update_html_canvas(self, html_canvas):
 
     def get_position(self, x: int, y: int):
         """Return the 3D position under canvas pixel (x, y) using the selection buffer."""
+        if self.canvas is None or self.canvas.height == 0:
+            return None
         objects = self.render_objects
 
         with self._render_mutex:
@@ -352,7 +354,7 @@ def select(self, x: int, y: int):
         """Perform an object selection at (x, y) and dispatch callbacks on matching renderers."""
         if self._render_mutex is None:
             return
-        if self.canvas is None:
+        if self.canvas is None or self.canvas.height == 0:
             return
         objects = self.render_objects
 
@@ -409,7 +411,7 @@ def select(self, x: int, y: int):
     # @print_communications
     def _render_objects(self, to_canvas=True, update_pipelines=True):
         """Update pipelines and render all active objects, optionally copying to the canvas."""
-        if self.canvas is None:
+        if self.canvas is None or self.canvas.height == 0:
             return
         options = self.options