Improve Parker weighting detection robustness for near-360° scans#743
Merged
Conversation
This PR improves the automatic Parker weighting detection in the FDK reconstruction. The previous condition could incorrectly classify a nearly complete 360° scan as a short scan due to small numerical errors or slight angular sampling inconsistencies. This modification introduces a tolerance of half an angular interval. In other words, if the missing angular coverage is within 0.5× the maximum angular step, the scan is still treated as a full 360° scan rather than enabling Parker weighting unnecessarily. This improves robustness while preserving correct short-scan detection. This issue was observed during 16× and higher sparse-view reconstructions using the Walnut dataset in WalnutPCCTReconCodes(https://github.com/zezisme/WalnutPCCTReconCodes), where near-360° scans could be incorrectly identified as short scans, unintentionally triggering Parker weighting.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the automatic Parker weighting detection in the FDK reconstruction.
The previous condition could incorrectly classify a nearly complete 360° scan as a short scan due to small numerical errors or slight angular sampling inconsistencies.
This modification introduces a tolerance of half an angular interval. In other words, if the missing angular coverage is within 0.5× the maximum angular step, the scan is still treated as a full 360° scan rather than enabling Parker weighting unnecessarily.
This improves robustness while preserving correct short-scan detection.
This issue was observed during 16× and higher sparse-view reconstructions using the photon-counting CT walnut dataset in WalnutPCCTReconCodes(built on TIGRE), where 360° scans could be incorrectly identified as short scans, unintentionally triggering Parker weighting.