Skip to content

Commit 211fd0f

Browse files
committed
fix gh/workflows/README.md
+ notice that the letter case for secrects doesn't matter - but use the upper case for Apple NOTARYTOOL_CREDENTIALS and APPLE_KEY_P12_B64 not to be confusing (and eg. case-sensitive grep(1) to work)
1 parent a303d04 commit 211fd0f

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

.github/workflows/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,21 @@ libraries for Linux (as does for macOS and Windows).
3939

4040
Secrets
4141
-------
42-
- **ALTOOL_CREDENTIALS** - Apple developer credentials to be used with
43-
notarytool for macOS build (username:password:teamid) notarization in
44-
format "user:password" (app-specific password is strongly recommended)
4542
- **APPIMAGE\_KEY** - GPG exported (armored) private key to sign AppImage;
4643
- **APPLE\_KEY\_P12\_B64** - base64-encoded Apple signing key in P12
4744
(see [below](#generating-apple-keys-to-sign-the-image))
4845
currently unused (no signing as for now - see the commit 2e321f65)
4946
- **COVERITY\_TOKEN** - Coverity token to be used for build (Coverity CI only)
47+
- **NOTARYTOOL_CREDENTIALS** - Apple developer credentials to be used with
48+
notarytool for macOS build (username:password:teamid) notarization in
49+
format "user:password" (app-specific password is strongly recommended)
5050
- **SDK\_URL** - URL where are located the [Dependencies](#dependencies) assets
5151
(currently Deltacast only)
5252

5353
**Note:** not all secrets are used by all workflows (see [Workflows](#workflows) for details)
5454

55+
**Note2:** secret names are _case-insensitive_
56+
5557
### Generating Apple keys to sign the image
5658

5759
This section contains a procedure to get and process keys to be used as _APPLE\_KEY\_P12\_B64_ above.
@@ -117,8 +119,8 @@ to release assets.
117119
* push to _other_ repositories (branch **master** or **v[0-9]+**) -
118120
creates build artifacts
119121

120-
This worflow utilizes **ALTOOL\_CREDENTIALS**, **APPLE\_KEY\_P12\_B64**,
121-
**APPIMAGE\_KEY** (currently not used, see above), **SDK\_URL**.
122+
This worflow utilizes **APPLE\_KEY\_P12\_B64**, **APPIMAGE\_KEY**
123+
(currently not used, see above), **NOTARYTOOL\_CREDENTIALS**,**SDK\_URL**.
122124

123125
The OS-specific runners are split to 3 YAML files, that can be triggered
124126
separately by pushing to the respecitve branches - the upload rules are

.github/workflows/macos.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ jobs:
2121
env:
2222
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2323
SDK_NONFREE_PATH: /private/var/tmp/sdks-nonfree
24-
notarytool_credentials: ${{ secrets.notarytool_credentials }}
25-
apple_key_p12_b64: ${{ secrets.apple_key_p12_b64 }}
24+
notarytool_credentials: ${{ secrets.NOTARYTOOL_CREDENTIALS }}
25+
apple_key_p12_b64: ${{ secrets.APPLE_KEY_P12_B64 }}
2626
SDK_URL: ${{ secrets.SDK_URL }}
2727

2828
steps:

0 commit comments

Comments
 (0)