Skip to content

Commit 34804de

Browse files
committed
fix transcoding reflector crash
eg. crashed: `hd-rum-transcode 8M 5004 -c lavc:c=H.264 -P 8000 ::1` fec should not be set to nullptr (RXTX init sets "none" by default)
1 parent d55a954 commit 34804de

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

src/hd-rum-translator/hd-rum-recompress.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ recompress_output_port::recompress_output_port(
129129
params.receiver = this->host.c_str();
130130
params.medium[TX_MEDIA_VIDEO].rx_port = rx_port;
131131
params.medium[TX_MEDIA_VIDEO].tx_port = tx_port;
132-
params.medium[TX_MEDIA_VIDEO].fec = fec;
132+
if (fec != nullptr) {
133+
params.medium[TX_MEDIA_VIDEO].fec = fec;
134+
}
133135
params.video_bitrate_limit = bitrate;
134136

135137
// UltraGrid RTP - fllowing already set by VRXTX_INIT

src/rxtx/rtp_common.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ init_medium_state(struct rtp_rxtx_common_priv_state *s,
309309
{ &video_offset, params->video_bitrate_limit,
310310
MODULE_CLASS_VIDEO },
311311
};
312+
assert(params_medium->fec != nullptr);
312313
const char *medium_str = get_tx_name(t);
313314
volatile int *medium_offset = medium_defaults[t].medium_offset;
314315
long long bitrate_limit = medium_defaults[t].bitrate_limit;

0 commit comments

Comments
 (0)