utils/misc: rm get_map_val_or_default

There is just a single occurence of that template so it is not worth
keeping it.

Author: MartinPulec

src/hd-rum-translator/hd-rum-recompress.cpp

@@ -43,6 +43,7 @@
 #include <cassert>
 #include <cinttypes>
 #include <chrono>
+#include <map>                                    // for map
 #include <memory>
 #include <thread>
 #include <string>

src/utils/misc.h

@@ -98,15 +98,6 @@ struct fourcc_s fourcc_to_string(uint32_t fourcc);
 #ifdef __cplusplus
 uint32_t parse_uint32(const char *value_str) noexcept(false);
 
-#include <map>
-template<typename key, typename T>
-inline T get_map_val_or_default(std::map<key, T> const& map, key const& k, T const& def) {
-        if (auto && it = map.find(k); it != map.end()) {
-                return it->second;
-        }
-        return def;
-}
-
 template<auto delete_fcn>
 struct deleter_from_fcn{ template<typename T> void operator()(T handle) const { delete_fcn(handle); }};
 

src/video_compress/libavcodec.cpp

@@ -2085,8 +2085,10 @@ static void configure_vaapi(AVCodecContext * /* codec_ctx */, struct setparam_pa
 
 static void configure_aom_av1(AVCodecContext *codec_ctx, struct setparam_param *param)
 {
-        auto && usage = get_map_val_or_default<string, string>(param->lavc_opts, "usage", "realtime");
-        check_av_opt_set<const char *>(codec_ctx->priv_data, "usage", usage.c_str());
+        auto it = param->lavc_opts.find("usage");
+        const char *usage =
+            it != param->lavc_opts.end() ? it->second.c_str() : "realtime";
+        check_av_opt_set<const char *>(codec_ctx->priv_data, "usage", usage);
         check_av_opt_set<const char *>(codec_ctx->priv_data, "tiles", "8x8");
 }