Skip to content

Commit 5a9c1ba

Browse files
committed
add HAVE_LIBJUICE to config.h instead of cmd opt
Added -DHAVE_LIBJUICE to config.h instead of passing as a compiler option argument. In the earlier case, reconfiguration with just holepunch state switched may not trigger rebuild (config.h not changed). Also consistent with most of other features. Also removed HAVE_LIBJUICE guard from the udp_holepunch.h header - no need to add config.h include for udp_holepunch.c.
1 parent 32ffb2a commit 5a9c1ba

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1084,7 +1084,7 @@ if test "$libjuice_req" != no; then
10841084
then
10851085
libjuice=yes
10861086
add_module holepunch src/utils/udp_holepunch.o "$LIBJUICE_LIB"
1087-
COMMON_FLAGS="$COMMON_FLAGS -DHAVE_LIBJUICE"
1087+
AC_DEFINE([HAVE_LIBJUICE], [1], [Linked with libjuice library])
10881088
fi
10891089
fi
10901090

src/utils/udp_holepunch.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ struct Holepunch_config{
6868
int stun_srv_port;
6969
};
7070

71-
#ifdef HAVE_LIBJUICE
7271
bool punch_udp(struct Holepunch_config *c);
73-
#endif
7472

7573
#ifdef __cplusplus
7674
} //extern "C"

0 commit comments

Comments
 (0)