vulkan: format_info: do not use std::array

The metadata array was actually positionally indexed, which was error prone.

Use rather switch - the advantage is that also a warning is issued if
some enum member not handled and also solves the above.

Author: MartinPulec

src/video_display/vulkan/vulkan_transfer_image.hpp

@@ -3,7 +3,7 @@
  * @author Martin Bela      <492789@mail.muni.cz>
  */
 /*
- * Copyright (c) 2021-2023 CESNET, z. s. p. o.
+ * Copyright (c) 2021-2025 CESNET, zajmové sdružení právnických osob
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -61,7 +61,6 @@ struct ImageDescription;
 namespace vulkan_display_detail {
 
 struct FormatInfo{
-        vulkan_display::Format format;
         vk::Format buffer_format;
         std::string conversion_shader = "";
         vk::Format conversion_image_format{};
@@ -72,22 +71,29 @@ inline const FormatInfo& format_info(vulkan_display::Format format){
         using F = vulkan_display::Format;
         using VkF = vk::Format;
 
-        static std::array<FormatInfo, 11> format_infos = {{
-{F::uninitialized,   VkF::eUndefined,            },
-{F::RGBA8,           VkF::eR8G8B8A8Unorm,        },
-{F::RGB8,            VkF::eR8G8B8Srgb,           },
-{F::UYVY8_422,       VkF::eB8G8R8G8422Unorm,     },
-{F::UYVY8_422_conv,  VkF::eR8G8B8A8Unorm,        {"UYVY8_conv"}, VkF::eR8G8B8A8Unorm},
-{F::YUYV8_422,       VkF::eG8B8G8R8422Unorm,     },
-{F::YUYV16_422,      VkF::eG16B16G16R16422Unorm, },
-{F::UYVA16_422_conv, VkF::eR16G16B16A16Uint,     {"UYVA16_conv"}, VkF::eR16G16B16A16Sfloat},
-{F::RGB10A2_conv,    VkF::eR8G8B8A8Uint,         {"RGB10A2_conv"}, VkF::eA2B10G10R10UnormPack32},
-{F::RGB16,          VkF::eR16G16B16Unorm        },
-        }};
-
-        auto& result = format_infos[static_cast<size_t>(format)];
-        assert(result.format == format);
-        return result;
+        static FormatInfo uninitialized =   { VkF::eUndefined,            };
+        static FormatInfo RGBA8 =           { VkF::eR8G8B8A8Unorm,        };
+        static FormatInfo RGB8 =            { VkF::eR8G8B8Srgb,           };
+        static FormatInfo UYVY8_422 =       { VkF::eB8G8R8G8422Unorm,     };
+        static FormatInfo UYVY8_422_conv =  { VkF::eR8G8B8A8Unorm,        {"UYVY8_conv"}, VkF::eR8G8B8A8Unorm};
+        static FormatInfo YUYV8_422 =       { VkF::eG8B8G8R8422Unorm,     };
+        static FormatInfo YUYV16_422 =      { VkF::eG16B16G16R16422Unorm, };
+        static FormatInfo UYVA16_422_conv = { VkF::eR16G16B16A16Uint,     {"UYVA16_conv"}, VkF::eR16G16B16A16Sfloat};
+        static FormatInfo RGB10A2_conv =    { VkF::eR8G8B8A8Uint,         {"RGB10A2_conv"}, VkF::eA2B10G10R10UnormPack32};
+        static FormatInfo RGB16 =           { VkF::eR16G16B16Unorm        };
+        switch (format) {
+                case F::uninitialized:   return uninitialized;
+                case F::RGBA8:           return RGBA8;
+                case F::RGB8:            return RGB8;
+                case F::UYVY8_422:       return UYVY8_422;
+                case F::UYVY8_422_conv:  return UYVY8_422_conv;
+                case F::YUYV8_422:       return YUYV8_422;
+                case F::YUYV16_422:      return YUYV16_422;
+                case F::UYVA16_422_conv: return UYVA16_422_conv;
+                case F::RGB10A2_conv:    return RGB10A2_conv;
+                case F::RGB16:           return RGB16;
+        };
+        abort();
 }
 
 vk::Extent2D get_buffer_size(const vulkan_display::ImageDescription& description);