logger: do not use get_time_in_ns for timestamp

use `timespec_get(... TIME_UTC)` instead directly

This is more clear and also slightly more efficient (avoiding convs).

The rationale was to decouple time_ns_t from wall-clock time. The
time_ns_t may be set later to CLOCK_MONOTONIC instead of CLOCK_REALTIME
(which corresponds to TIME_UTC). As for now, these timestamps in the
logger are in time from epoch. (Other variants like time from UG start
can be also considered later but REALITME /likely the time from marchine
boot/ doesn't seem much useful).

Author: MartinPulec

src/debug.h

@@ -40,14 +40,12 @@
 
 #ifdef __cplusplus
 #include <cstdint>
-#include <cstdio> // FILE
+#include <ctime>  // timespec_get
 #else
 #include <stdbool.h>
 #include <stdint.h>
-#include <stdio.h> // FILE
 #endif // defined __cplusplus
 
-#include "tv.h"
 
 #define UNUSED(x)	(x=x)
 
@@ -252,9 +250,11 @@ inline void Log_output::submit(){
         if (show_timestamps == LOG_TIMESTAMP_ENABLED
                 || (show_timestamps == LOG_TIMESTAMP_AUTO && log_level >= LOG_LEVEL_VERBOSE))
         {
-                const time_ns_t time_ns = get_time_in_ns();
-                snprintf(ts_str, ts_bufsize, "[%.3f] ",
-                         (double) time_ns / NS_IN_SEC_DBL);
+                std::timespec ts{};
+                std::timespec_get(&ts, TIME_UTC);
+                snprintf(ts_str, ts_bufsize, "[%lld.%3d] ",
+                         (long long) ts.tv_sec,
+                         (int) (ts.tv_nsec / 1000 / 1000));
         }
 
         const char *start_newline = "";

src/tfrc.c

@@ -44,17 +44,16 @@
  *
  */
 
-#include <stdbool.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <assert.h>
-
-#include "config.h"
-#include "debug.h"
-#include "rtp/rtp.h"
-#include "tv.h"
 #include "tfrc.h"
 
+#include <assert.h>  // for assert
+#include <stdint.h>  // for uint32_t, uint16_t
+#include <stdio.h>   // for printf, NULL
+#include <stdlib.h>  // for abort, free, malloc
+
+#include "debug.h"   // for LOG_LEVEL_DEBUG, log_level
+#include "tv.h"      // for time_ns_t, NS_IN_SEC, get_time_in_ns
+
 #define TFRC_MAGIC	0xbaef03b7      /* For debugging */
 
 #define MAX_HISTORY		1000

src/tfrc.h

@@ -43,6 +43,12 @@
  *
  */
 
+#ifdef __cplusplus
+#include <cstdint>   // for uint16_t, uint32_t
+#else
+#include <stdint.h>  // for uint16_t, uint32_t
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif

test/test_des.c

@@ -38,10 +38,12 @@
  * SUCH DAMAGE.
  */
 
+#include "test_des.h"
+
 #include <string.h>
-#include "debug.h"
+#include <stdio.h>
+
 #include "crypto/crypt_des.h"
-#include "test_des.h"
 
 #define NUM_TESTS 36
 

test/test_net_udp.c

@@ -34,17 +34,19 @@
  * SUCH DAMAGE.
  */
 
+#include "test_net_udp.h"
+
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
+#include <sys/time.h>     // for timeval
 #ifndef WIN32
 #include <sys/wait.h>
 #endif
+#include <time.h>
 
-#include "debug.h"
+#include "compat/net.h"   // for HAVE_IPv6, fork
 #include "rtp/net_udp.h"
-#include "test_net_udp.h"
-
-#include <string.h>
 
 #define BUFSIZE 1024