server config BUGFIX proper call-home config access

michalvasko · michalvasko · commit 956e73fc850b · 2025-05-26T13:27:14.000+02:00
Fixes #1686
diff --git a/src/server_config.c b/src/server_config.c
@@ -474,7 +474,7 @@ nc_server_config_get_private_key_type(const char *format)
 
 #endif /* NC_ENABLED_SSH_TLS */
 
-/* gets the ch_client struct based on node's location in the YANG data tree and locks it for reading */
+/* gets the ch_client struct based on node's location in the YANG data tree and locks it for writing, it is being modified */
 static int
 nc_server_config_get_ch_client_with_lock(const struct lyd_node *node, struct nc_ch_client **ch_client)
 {
@@ -489,7 +489,7 @@ nc_server_config_get_ch_client_with_lock(const struct lyd_node *node, struct nc_
     }
 
     /* LOCK */
-    pthread_rwlock_rdlock(&server_opts.ch_client_lock);
+    pthread_rwlock_wrlock(&server_opts.ch_client_lock);
     for (i = 0; i < server_opts.ch_client_count; i++) {
         if (!strcmp(server_opts.ch_clients[i].name, name)) {
             /* LOCK */

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ nc_server_config_get_private_key_type(const char *format)`
`474`	`474`
`475`	`475`	`#endif /* NC_ENABLED_SSH_TLS */`
`476`	`476`
`477`		`-/* gets the ch_client struct based on node's location in the YANG data tree and locks it for reading */`
	`477`	`+/* gets the ch_client struct based on node's location in the YANG data tree and locks it for writing, it is being modified */`
`478`	`478`	`static int`
`479`	`479`	`nc_server_config_get_ch_client_with_lock(const struct lyd_node node, struct nc_ch_client *ch_client)`
`480`	`480`	`{`
`@@ -489,7 +489,7 @@ nc_server_config_get_ch_client_with_lock(const struct lyd_node *node, struct nc_`
`489`	`489`	`}`
`490`	`490`
`491`	`491`	`/* LOCK */`
`492`		`- pthread_rwlock_rdlock(&server_opts.ch_client_lock);`
	`492`	`+ pthread_rwlock_wrlock(&server_opts.ch_client_lock);`
`493`	`493`	`for (i = 0; i < server_opts.ch_client_count; i++) {`
`494`	`494`	`if (!strcmp(server_opts.ch_clients[i].name, name)) {`
`495`	`495`	`/* LOCK */`