schema UPDATE include revision in err messages

Author: michalvasko

src/schema_features.c

@@ -605,7 +605,8 @@ lys_set_features(struct lysp_module *pmod, const char **features)
         /* check that all the features exist */
         for (j = 0; features[j]; ++j) {
             if (!lysp_feature_find(pmod, features[j], strlen(features[j]), 0)) {
-                LOGERR(pmod->mod->ctx, LY_EINVAL, "Feature \"%s\" not found in module \"%s\".", features[j], pmod->mod->name);
+                LOGERR(pmod->mod->ctx, LY_EINVAL, "Feature \"%s\" not found in module \"%s@%s\".", features[j],
+                        pmod->mod->name, pmod->mod->revision ? pmod->mod->revision : "<none>");
                 return LY_EINVAL;
             }
         }

src/tree_schema_common.c

@@ -840,7 +840,7 @@ lys_load_mod_from_clb_or_file(struct ly_ctx *ctx, const char *name, const char *
     }
 
     if (!*mod && !mod_latest) {
-        LOGVAL(ctx, NULL, LYVE_REFERENCE, "Loading \"%s\" module failed, not found.", name);
+        LOGVAL(ctx, NULL, LYVE_REFERENCE, "Loading \"%s@%s\" module failed, not found.", name, revision ? revision : "<any>");
         return LY_ENOTFOUND;
     }
 

tests/utests/schema/test_tree_schema_compile.c

@@ -99,7 +99,7 @@ test_module(void **state)
     ly_in_free(in, 0);
     assert_int_equal(0, mod->implemented);
     assert_int_equal(LY_EINVAL, lys_set_implemented(mod, feats));
-    CHECK_LOG_CTX("Feature \"invalid\" not found in module \"test\".", NULL, 0);
+    CHECK_LOG_CTX("Feature \"invalid\" not found in module \"test@<none>\".", NULL, 0);
     assert_int_equal(LY_SUCCESS, lys_set_implemented(mod, NULL));
     assert_non_null(mod->compiled);
     assert_string_equal("test", mod->name);

tests/yanglint/interactive/searchpath.test

@@ -18,7 +18,7 @@ test searchpath_clear {searchpath --clear} {
 -setup $ly_setup -cleanup $ly_cleanup -body {
     ly_cmd "searchpath $mdir"
     ly_cmd "searchpath --clear"
-    ly_cmd_err "load modleaf" "Loading \"modleaf\" module failed, not found."
+    ly_cmd_err "load modleaf" "Loading \"modleaf@<any>\" module failed, not found."
 }}
 
 cleanupTests

tests/yanglint/non-interactive/disabled_searchdir.test

@@ -4,7 +4,7 @@ set mdir $env(YANG_MODULES_DIR)
 
 test disable_searchdir_twice {Unsuccessfully imports module due to -D -D} {
     ly_cmd "$mdir/ietf-ip.yang"
-    ly_cmd_err "-D -D $mdir/ietf-ip.yang" "Loading \"ietf-interfaces\" module failed."
+    ly_cmd_err "-D -D $mdir/ietf-ip.yang" "Loading \"ietf-interfaces@<any>\" module failed."
 } {}
 
 cleanupTests