tree UPDATE minor improvements

Author: michalvasko

src/tree_data_new.c

@@ -589,8 +589,9 @@ LIBYANG_API_DEF LY_ERR
 lyd_new_list2(struct lyd_node *parent, const struct lys_module *module, const char *name, const char *keys,
         uint32_t options, struct lyd_node **node)
 {
+    LY_ERR r;
     struct lyd_node *ret = NULL;
-    const struct lysc_node *schema;
+    const struct lysc_node *schema = NULL;
     struct lysc_ext_instance *ext = NULL;
     const struct ly_ctx *ctx = parent ? LYD_CTX(parent) : (module ? module->ctx : NULL);
     uint32_t getnext_opts = (options & LYD_NEW_VAL_OUTPUT) ? LYS_GETNEXT_OUTPUT : 0;
@@ -606,11 +607,12 @@ lyd_new_list2(struct lyd_node *parent, const struct lys_module *module, const ch
     }
 
     /* find schema node */
-    schema = lys_find_child(ctx, parent ? parent->schema : NULL, module, NULL, 0, name, 0, getnext_opts);
-    if (schema && (schema->nodetype != LYS_LIST)) {
-        schema = NULL;
+    r = lys_find_child_node(ctx, parent ? parent->schema : NULL, module, NULL, 0, 0, NULL, name, 0, getnext_opts,
+            &schema, &ext);
+    if (!r && (schema->nodetype != LYS_LIST)) {
+        r = LY_ENOT;
     }
-    LY_CHECK_ERR_RET(!schema, LOGERR(ctx, LY_EINVAL, "List node \"%s\" not found.", name), LY_ENOTFOUND);
+    LY_CHECK_ERR_RET(r, LOGERR(ctx, LY_EINVAL, "List node \"%s\" not found.", name), LY_ENOTFOUND);
 
     if ((schema->flags & LYS_KEYLESS) && !keys[0]) {
         /* key-less list */

src/tree_schema.c

@@ -544,6 +544,8 @@ lys_find_child_node(const struct ly_ctx *ctx, const struct lysc_node *parent, co
 {
     const struct lysc_node *node = NULL;
 
+    assert(name);
+
     *snode = NULL;
     if (ext) {
         *ext = NULL;
@@ -552,7 +554,7 @@ lys_find_child_node(const struct ly_ctx *ctx, const struct lysc_node *parent, co
     if (prefix && !prefix_len) {
         prefix_len = strlen(prefix);
     }
-    if (name && !name_len) {
+    if (!name_len) {
         name_len = strlen(name);
     }
 
@@ -603,7 +605,7 @@ lys_find_child(const struct ly_ctx *ctx, const struct lysc_node *parent, const s
     if (mod_name && !mod_len) {
         mod_len = strlen(mod_name);
     }
-    if (name && !name_len) {
+    if (!name_len) {
         name_len = strlen(name);
     }