context BUGFIX manually free pcodes for a printed context

Author: michalvasko

src/context.c

@@ -1496,7 +1496,8 @@ ly_ctx_destroy(struct ly_ctx *ctx)
 
     if (ctx->opts & LY_CTX_INT_IMMUTABLE) {
         if (!ctx->parent_ctx) {
-            /* ctx data */
+            /* cached patterns and ctx data */
+            ly_ctx_pattern_ht_erase(ctx);
             ly_ctx_data_del(ctx);
         }
         lyplg_clean();

src/ly_common.c

@@ -534,13 +534,22 @@ ly_ctx_data_del(const struct ly_ctx *ctx)
 }
 
 void
-ly_ctx_ht_pattern_rec_free(struct ly_pattern_ht_rec *rec)
+ly_ctx_pattern_ht_erase(const struct ly_ctx *ctx)
 {
-    if (!rec) {
-        return;
+    struct ly_ctx_shared_data *ctx_data;
+    struct ly_ht_rec *rec;
+    uint32_t hlist_idx, rec_idx;
+
+    ctx_data = ly_ctx_shared_data_get(ctx);
+
+    /* free all the stored records */
+    LYHT_ITER_ALL_RECS(ctx_data->pattern_ht, hlist_idx, rec_idx, rec) {
+        pcre2_code_free(((struct ly_pattern_ht_rec *)&rec->val)->pcode);
     }
 
-    pcre2_code_free(rec->pcode);
+    /* we have removed all patterns (so it is empty), we can not free the ht here though, to avoid
+     * double free, but just trick it to look empty */
+    ctx_data->pattern_ht->used = 0;
 }
 
 LY_ERR

src/ly_common.h

@@ -503,11 +503,11 @@ LY_ERR ly_ctx_shared_data_pattern_get(const struct ly_ctx *ctx, const char *patt
 void ly_ctx_shared_data_pattern_del(const struct ly_ctx *ctx, const char *pattern);
 
 /**
- * @brief Free members of a pattern record stored in the context hash table.
+ * @brief Free members of a pattern record stored in the context shared data hash table.
  *
- * @param[in] rec Pattern records whose members to free.
+ * @param[in] ctx Context to use.
  */
-void ly_ctx_ht_pattern_rec_free(struct ly_pattern_ht_rec *rec);
+void ly_ctx_pattern_ht_erase(const struct ly_ctx *ctx);
 
 /******************************************************************************
  * Dictionary

src/plugins_exts.c

@@ -763,10 +763,6 @@ LIBYANG_API_DEF LY_ERR
 lyplg_ext_set_parent_ctx(struct ly_ctx *ctx, const struct ly_ctx *parent_ctx)
 {
     const struct ly_ctx *c;
-    struct ly_ctx_shared_data *ctx_data;
-    struct ly_ht_rec *rec;
-    uint32_t hlist_idx;
-    uint32_t rec_idx;
 
     LY_CHECK_ARG_RET(ctx, ctx, LY_EINVAL);
 
@@ -793,14 +789,7 @@ lyplg_ext_set_parent_ctx(struct ly_ctx *ctx, const struct ly_ctx *parent_ctx)
         } else {
             /* remove its shared and private data, this is an exception as we need to free compiled patterns
              * manually, since we are not destroying the whole context, we will just be using the parent's ctx data instead */
-            ctx_data = ly_ctx_shared_data_get(ctx);
-            LYHT_ITER_ALL_RECS(ctx_data->pattern_ht, hlist_idx, rec_idx, rec) {
-                ly_ctx_ht_pattern_rec_free((struct ly_pattern_ht_rec *)&rec->val);
-            }
-
-            /* we have removed all patterns (so it is empty), we can not free the ht here though, to avoid
-             * double free, but just trick it to look empty */
-            ctx_data->pattern_ht->used = 0;
+            ly_ctx_pattern_ht_erase(ctx);
             ly_ctx_data_del(ctx);
         }
     } else if (!parent_ctx) {