Update CI and oldest docker image

Author: tpadioleau

.github/workflows/tests-macos.yaml

@@ -113,9 +113,7 @@ jobs:
           path: ginkgo
       - name: Install Ginkgo
         run: |
-          # Ginkgo 1.8 needs the flags "-undefined dynamic_lookup" to link, recent versions should not need it
           cmake \
-            -D CMAKE_SHARED_LINKER_FLAGS="-undefined dynamic_lookup" \
             -D GINKGO_BUILD_BENCHMARKS=OFF \
             -D GINKGO_BUILD_EXAMPLES=OFF \
             -D GINKGO_BUILD_MPI=OFF \

.github/workflows/tests-ubuntu.yaml

@@ -127,7 +127,7 @@ jobs:
           - name: 'cpu'
             c_compiler: 'gcc'
             cxx_compiler: 'g++'
-        cxx_version: ['17']
+        cxx_version: ['20']
         cmake_build_type: ['None']
     runs-on: ubuntu-latest
     needs: [docker-build, id_repo]
@@ -224,18 +224,14 @@ jobs:
             cxx_compiler: 'hipcc'
             ddc_extra_cxx_flags: ''
             kokkos_extra_cmake_flags: '-D Kokkos_ENABLE_HIP=ON -D Kokkos_ENABLE_HIP_RELOCATABLE_DEVICE_CODE=ON -D Kokkos_ENABLE_ROCTHRUST=OFF -D Kokkos_ARCH_AMD_GFX90A=ON'
-        cxx_version: ['17', '20', '23']
+        cxx_version: ['20', '23']
         build_type:
           - cmake_build_type: 'Release'
             cxx_flags: ''
           - cmake_build_type: 'Debug'
             cxx_flags: '-O1'
         exclude:
-          - image: 'oldest'  # nvcc 11 only supports C++-17
-            backend:
-              name: 'cuda'
-            cxx_version: '20'
-          - image: 'oldest'  # nvcc 11 only supports C++-17
+          - image: 'oldest'  # nvcc 12 only supports C++-20
             backend:
               name: 'cuda'
             cxx_version: '23'
@@ -421,7 +417,7 @@ jobs:
           - name: 'cpu'
             c_compiler: 'gcc'
             cxx_compiler: 'g++'
-        cxx_version: ['17']
+        cxx_version: ['20']
         cmake_build_type: ['Debug']
         sanitizer: ['address', 'undefined']
     runs-on: ubuntu-latest
@@ -522,7 +518,7 @@ jobs:
           - name: 'cpu'
             c_compiler: 'clang-21'
             cxx_compiler: 'clang++-21'
-        cxx_version: ['17']
+        cxx_version: ['20']
         cmake_build_type: ['Release']
     runs-on: ubuntu-latest
     needs: [docker-build, id_repo]

docker/oldest/Dockerfile

@@ -7,12 +7,12 @@ FROM ubuntu:jammy@sha256:3ba65aa20f86a0fad9df2b2c259c613df006b2e6d0bfcc8a146afb8
 LABEL "org.opencontainers.image.source"="https://github.com/CExA-project/ddc"
 
 ARG BACKEND
-ARG AMDGPU_VERSION=5.7.3
+ARG AMDGPU_VERSION=6.2.4
 ARG CMAKE_VERSION=3.25.3
-ARG CUDA_MAJOR_VERSION=11
-ARG CUDA_MINOR_VERSION=8
+ARG CUDA_MAJOR_VERSION=12
+ARG CUDA_MINOR_VERSION=2
 ARG GINKGO_VERSION=1.8.0
-ARG ROCM_VERSION=5.7.3
+ARG ROCM_VERSION=6.2.4
 
 COPY bash_run /bin/
 ENV BASH_ENV=/etc/profile
@@ -73,12 +73,11 @@ RUN chmod +x /bin/bash_run \
       libcufft-dev-${CUDA_MAJOR_VERSION}-${CUDA_MINOR_VERSION} \
       libcurand-dev-${CUDA_MAJOR_VERSION}-${CUDA_MINOR_VERSION} \
       libcusparse-dev-${CUDA_MAJOR_VERSION}-${CUDA_MINOR_VERSION} \
-      gcc-10 \
-      g++-10 \
  ;; "hip") \
       apt-get install -y --no-install-recommends \
       hipblas-dev${ROCM_VERSION} \
       hipfft-dev${ROCM_VERSION} \
+      hiprand-dev${ROCM_VERSION} \
       hipsparse-dev${ROCM_VERSION} \
       rocm-hip-runtime-dev${ROCM_VERSION} \
       rocrand-dev${ROCM_VERSION} \
@@ -95,9 +94,13 @@ RUN chmod +x /bin/bash_run \
     "cpu") \
       cmake -DCMAKE_BUILD_TYPE=Release -DGINKGO_BUILD_OMP=ON -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -B ginkgo/build -S ginkgo \
  ;; "cuda") \
-      cmake -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10 -DCMAKE_CUDA_HOST_COMPILER=g++-10 -DCMAKE_BUILD_TYPE=Release -DGINKGO_CUDA_ARCHITECTURES=70 -DGINKGO_BUILD_CUDA=ON -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -B ginkgo/build -S ginkgo \
+      cmake -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_CUDA_HOST_COMPILER=g++ -DCMAKE_BUILD_TYPE=Release -DGINKGO_CUDA_ARCHITECTURES=70 -DGINKGO_BUILD_CUDA=ON -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -B ginkgo/build -S ginkgo \
  ;; "hip") \
-      cmake -DCMAKE_PREFIX_PATH=/opt/rocm -DCMAKE_BUILD_TYPE=Release -DCMAKE_HIP_ARCHITECTURES=gfx90a -DGINKGO_BUILD_HIP=ON -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -B ginkgo/build -S ginkgo \
+      # HIP_PATH needs to be set to avoid Ginkgo defining it (https://github.com/ginkgo-project/ginkgo/blob/develop/cmake/hip_path.cmake).
+      # The Ginkgo <1.9 heuristic does not seem to be compatible with the new HIP v6 directory layout.
+      # This makes amdclang++ fail during cmake compiler test (https://releases.llvm.org/18.1.0/tools/clang/docs/HIPSupport.html#order-of-precedence-for-hip-path)
+      export HIP_PATH=`hipconfig --path` \
+      && cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_HIP_ARCHITECTURES=gfx90a -DGINKGO_BUILD_HIP=ON -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -B ginkgo/build -S ginkgo \
  ;; esac \
  && cmake --build ginkgo/build \
  && cmake --install ginkgo/build --prefix /usr \
@@ -113,8 +116,8 @@ RUN chmod +x /bin/bash_run \
  && rm -rf /var/lib/apt/lists/* \
  && useradd -d /data -m -U ci \
  && if [ "xcuda" = "x${BACKEND}" ] \
-  ; then echo 'CUDA_GCC=gcc-10' > /etc/profile.d/ddc-cuda.sh \
-       ; echo 'CUDA_GXX=g++-10' >> /etc/profile.d/ddc-cuda.sh \
+  ; then echo 'CUDA_GCC=gcc' > /etc/profile.d/ddc-cuda.sh \
+       ; echo 'CUDA_GXX=g++' >> /etc/profile.d/ddc-cuda.sh \
  ;  fi
 
 USER ci:ci