You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@joaquinffernandez@francosansone Does it makes sense that the partitioner inside SBG compiles with the library? If not, I can modify the Makefile. I think that the algorithms should be part of the library too.
P.S. I will also move the other algorithms (matching, SCC, etc.) inside the algorithms/ directory.
Yes, I think it does. I think the main file should link the library in compilation time, since it should not depend on the changes we do on the implementation and it also gives us an use case to test if the library works.
If not, I can modify the Makefile. I think that the algorithms should be part of the library too. P.S. I will also move the other algorithms (matching, SCC, etc.) inside the algorithms/ directory.
I totally agree, except for the main file, the rest of the code should part of the sb-graph library. In the future we could think about if we want to split it as a new library (for example, if sb-graph becomes too large).
If not, I can modify the Makefile. I think that the algorithms should be part of the library too. P.S. I will also move the other algorithms (matching, SCC, etc.) inside the algorithms/ directory.
I agree, in the future we might consider split the functionalities if it becomes too big, but for the moment I think we are OK
Not related to this PR, but commands make install and make install-folders should add header files in algorithms/partitioner/. Currently, functions and classes defined there are not accessible from sb-graph library users.
Regarding the Makefile changes, the overall structure is quite better now, I will change the build system to cmake but now it's much easier to migrate.
When that's done I can modify the include rules and readme files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingenhancementNew feature or request
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See related issue.