Fixed numpy linalg error

Author: jmafoster1

causal_testing/discovery/abstract_discovery.py

@@ -10,6 +10,7 @@
 from itertools import permutations
 
 import networkx as nx
+import numpy as np
 import pandas as pd
 import rustworkx as rx
 
@@ -207,28 +208,27 @@ def evaluate_tests(self, causal_dag: CausalDAG) -> pd.DataFrame:
 
         results = []
 
-        # We use "silent=False" here to allow for inestimable edges, but it'd be good to have a more stringent
-        # error catching strategy to catch "genuine" problems (e.g. to do with the structure of the data)
-        for test_case, result in zip(ctf.test_cases, ctf.run_tests(silent=False)):
-            if result.effect_estimate is None:
+        for test_case, result in zip(ctf.test_cases, ctf.test_cases):
+            try:
+                result = test_case.execute_test()
                 results.append(
                     {
-                        "result": TestResult.INESTIMABLE,
+                        "result": (
+                            TestResult.PASS if test_case.expected_causal_effect.apply(result) else TestResult.FAIL
+                        ),
                         "expected_effect": test_case.expected_causal_effect.__class__.__name__,
                         "treatment": test_case.base_test_case.treatment_variable.name,
                         "outcome": test_case.base_test_case.outcome_variable.name,
+                        "effect": effect_direction(result),
                     }
                 )
-            else:
+            except np.linalg.LinAlgError:
                 results.append(
                     {
-                        "result": (
-                            TestResult.PASS if test_case.expected_causal_effect.apply(result) else TestResult.FAIL
-                        ),
+                        "result": TestResult.INESTIMABLE,
                         "expected_effect": test_case.expected_causal_effect.__class__.__name__,
                         "treatment": test_case.base_test_case.treatment_variable.name,
                         "outcome": test_case.base_test_case.outcome_variable.name,
-                        "effect": effect_direction(result),
                     }
                 )