Jmafoster1/visualisation - #403
Draft
jmafoster1 wants to merge 5 commits into
Draft
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 31 | 1 | 1.21s | ||
| ✅ PYTHON | pylint | 31 | 0 | 5.8s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
jmafoster1
commented
Jul 31, 2026
| raise ValueError(f"Test Value type {effect_estimate.type} is not valid for this CausalEffect") | ||
|
|
||
| return (~((effect_estimate.ci_low <= value_to_check) & (value_to_check <= effect_estimate.ci_high))).all() | ||
| return (~((effect_estimate.ci_low <= value_to_check) & (value_to_check <= effect_estimate.ci_high))).any() |
Collaborator
Author
There was a problem hiding this comment.
Bug fix: This should have been .any() all along
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to visualise causal test results on the DAG.
Main changes
abstract_discovery.pyand into a separate dedicated visualisation module, which can grow sustainably over timeeffect_directionintoCausalTestResultclass. Ideally, this would be part ofEffectEstimate, but that leads to circular imports withCausalEffect